-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[docs] Fix runtime feature detection documentation #16746
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also somehow expose USE_CPP_PACKAGE
runtime features currently doesn't track those flags.
Don't want to block otherwise. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM...
@aaronmarkham @zachgk @lanking520 can we merge this? |
@ChaiBapchya does CPP affect the library build? |
You have to build from source with that flag in order to use CPP. You can't just take a lib you built without the flag and setup the binding (like you do with the other lang bindings)... if that's what you're asking... At least, this is my understanding. |
That's a good call for contributions in that case. |
Description
as title.
Documentation was not appearing in the index nor sidebar.
Adds usage example to mxnet.runtime
@ThomasDelteil @aaronmarkham