This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[Numpy] Add NumPy support for np.linalg.det and np.linalg.slogdet #16800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vexilligera
changed the title
[WIP][Numpy] np.linalg.det and np.linalg.slogdet
[WIP][DO NOT MERGE][Numpy] np.linalg.det and np.linalg.slogdet
Nov 13, 2019
@mxnet-label-bot add [Numpy] |
hzfan
reviewed
Nov 14, 2019
vexilligera
changed the title
[WIP][DO NOT MERGE][Numpy] np.linalg.det and np.linalg.slogdet
[Numpy] Add NumPy support for np.linalg.det and np.linalg.slogdet
Nov 15, 2019
reminisce
reviewed
Nov 15, 2019
vexilligera
commented
Nov 17, 2019
reminisce
reviewed
Nov 21, 2019
reminisce
reviewed
Nov 21, 2019
reminisce
approved these changes
Nov 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The flakiness in #16415 was caused by a typo in LaOpDetBackward, which resulted in array index out of bound. The reason it only happened on Windows and was susceptible to the presence of call to broadcast in slogdet_backward may have something to do with the Windows Release image stack memory layout. I guess the Linux binary was simply a bit more tolerant.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments