-
Notifications
You must be signed in to change notification settings - Fork 6.8k
updating MXNet version to 1.6.0 in base.h for C APIs #16905
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a key problem with the publish, we should bump it once we make the release
yes |
@access2rohit shouldnt we be changing master to 1.7? |
@samskalicky Sure! I think we should first bump master to 1.6 and then again to 1.7. Does that makes sense ? |
@access2rohit Since the 1.6.x branch is already diverged from master, there is no need to do this 1.6 step I think - we should just go directly to 1.7 (which I believe requires changes in more places). |
Yes it requires changes in more places. IMO we should follow proper progression by moving from 1.5->1.6->1.7 to keep the change history in master clean and consistent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'm fine with this change first.
Description
updating MXNet version to 1.6.0 in base.h for C APIs
#16904
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.