Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] fix model zoo parallel download #17372

Merged
merged 6 commits into from
Jan 24, 2020
Merged

[BUGFIX] fix model zoo parallel download #17372

merged 6 commits into from
Jan 24, 2020

Conversation

eric-haibin-lin
Copy link
Member

Description

Fixes #17332

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin eric-haibin-lin requested a review from szha as a code owner January 18, 2020 08:01
@eric-haibin-lin eric-haibin-lin mentioned this pull request Jan 18, 2020
Closed
7 tasks
ChaiBapchya
ChaiBapchya approved these changes Jan 19, 2020
View reviewed changes
Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

python/mxnet/gluon/utils.py Outdated Show resolved Hide resolved
@eric-haibin-lin
Copy link
Member Author

I keep getting permission denied when tempfile is used... http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Fwindows-cpu/detail/PR-17372/4/pipeline/175

@leezu @apeforest any idea why?

leezu
leezu approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@leezu leezu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@leezu leezu merged commit 4a13edd into apache:master Jan 24, 2020
@eric-haibin-lin
Copy link
Member Author

@ptrendx can we cherrypick this fix to 1.6?

@leezu leezu added the R1.6.0 label Jan 24, 2020
eric-haibin-lin added a commit to eric-haibin-lin/mxnet that referenced this pull request Jan 24, 2020
@eric-haibin-lin
[BUGFIX] fix model zoo parallel download (apache#17372)
be17693 
* use temp file

* fix dependency

* Update model_store.py

* Update test_gluon_model_zoo.py

* remove NamedTempFile
@eric-haibin-lin eric-haibin-lin mentioned this pull request Jan 24, 2020
Merged
7 tasks
eric-haibin-lin added a commit that referenced this pull request Jan 24, 2020
@eric-haibin-lin
[BUGFIX] fix model zoo parallel download (#17372)
69f4f31 
* use temp file

* fix dependency

* Update model_store.py

* Update test_gluon_model_zoo.py

* remove NamedTempFile
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChaiBapchya ChaiBapchya ChaiBapchya approved these changes

@leezu leezu leezu approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
R1.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race condition in downloading model from model zoo in parallel
3 participants
@eric-haibin-lin @leezu @ChaiBapchya