-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The WIP disclaimer should replace the content of the existing disclaimer, not to be included side by side with the old disclaimer
Nevermind. The examples I found doesn't conform to the requirement in the disclaimer guideline page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like in other projects only the WIP disclaimer is kept.
See:
https://github.com/apache/incubator-hudi
https://github.com/apache/incubator-doris
Yes, i think the file should be kept separate according to here
re-trigger CI. |
rebased and Jenkins God please no time-out 🙏 🙏 🙏 |
replaced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tools/pip/MANIFEST.in
also needs to be updated.
done |
* add disclaimer * add white list * fix exclude * remove disclaimer * update tools/pip
* Update NOTICE to fix copyright years (#17330) * Update LICENSE for fonts (#17365) * license np_einsum file under bsd (#17367) * license under bsd * fix rat exclude * remove unused file with license issue (#17371) * [LICENSE] fix cpp predcit license (#17377) * fix cpp predcit license * add white list (#210) * fix white list (#211) Co-authored-by: Lai Wei <[email protected]> * add disclaimer (#17428) * add disclaimer * add white list * fix exclude * remove disclaimer * update tools/pip Co-authored-by: Haibin Lin <[email protected]>
address #17329 (comment)
so we can move forward with 1.6 release.
cc @ptrendx @szha @leezu @samskalicky