This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
MXNET-1444/MXNET-1445: replace NULL by nullptr literal #17536
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
olk
commented
Feb 6, 2020
•
edited
Loading
edited
- using nullptr is more explicit
- macro NULL can be a integer literal with value zero (since C++11)
- literal nullptr is of type std::nullptr_t
- as template arg NULL and 0 evaluate to integer
- MXNET-1444 - using nullptr is more explicit - macro NULL can be a integer literal with value zero (since C++11) - literal nullptr is of type std::nullptr_t - as template arg NULL and 0 evaluate to integer
- MXNET-1445 - using nullptr is more explicit - macro NULL can be a integer literal with value zero (since C++11) - literal nullptr is of type std::nullptr_t - as template arg NULL and 0 evaluate to integer
olk
requested review from
anirudh2290,
eric-haibin-lin and
nswamy
as code owners
February 6, 2020 19:22
Please see CI, lint is failing:
|
Sorry, I didn't paste the exact error message but only the error summary before. |
* Add np.random.pareto and np.random.power; add one test for pareto, power, weibull * Remove previous Weibull test
* stub for optimizing Gluon block * Init commit for Gluon hybridblocks partition(sample test included) * Added tests for Gluon and refactored tests * call optimize_for in _build_cache * Pass in 4 paras for gluon optimize_for * Fixed auxiliary state issue, args issue and added 2 tests. * Fixed auxiliary state issue, args issue and added 2 tests. * changed parameter check * refactored param init since needed for partitioning * fixed whitespace * fixed flattened args * fixed sanity & updated tests * fixed whitespace * added context support in tests * Fix python2 errors * clean code remove cargs * Add hybridblock hybridize() description Co-authored-by: guanxinq <[email protected]>
* Added support for remaining random sampling ops, removed exception for sample_multinomial as it does work with random data * Dropped unused unique_ops variable * Added affine transform, dropped parentheses, changed 19 to 18 * Dropped unique_ops condition - no longer in use * Fixed indentation * Dropped unique_ops
There was an additional whitespace error from a previous commit - I don't know why it could pass the lint check. Could I get a link to the coding/code formatting standards used by MXNet? |
- MXNET-1445
generating Julia docs fails with:
Seams to be an problem of the build system. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.