Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix parse operator attributes in new FFI #18284

Merged
merged 3 commits into from
May 15, 2020
Merged

Fix parse operator attributes in new FFI #18284

merged 3 commits into from
May 15, 2020

Conversation

leezu
Copy link
Contributor

@leezu leezu commented May 12, 2020

Description

Previously attributes are only parsed if autograd is active, causing #18004

@mxnet-bot
Copy link

Hey @leezu , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [sanity, centos-cpu, edge, miscellaneous, unix-gpu, clang, website, windows-gpu, windows-cpu, unix-cpu, centos-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@leezu leezu changed the title Always parse operator attributes in new FFI Fix parse operator attributes in new FFI May 12, 2020
@leezu
Copy link
Contributor Author

leezu commented May 12, 2020

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@leezu leezu requested review from haojin2 and szha May 13, 2020 18:13
@leezu leezu added the pr-awaiting-review PR is waiting for code review label May 13, 2020
@leezu
Copy link
Contributor Author

leezu commented May 14, 2020

@mxnet-bot run ci [unix-cpu, centos-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu, centos-cpu]

@leezu
Copy link
Contributor Author

leezu commented May 15, 2020

@mxnet-bot run ci [unix-cpu, centos-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu, centos-cpu]

@leezu
Copy link
Contributor Author

leezu commented May 15, 2020

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@leezu leezu removed the pr-awaiting-review PR is waiting for code review label May 15, 2020
@leezu leezu merged commit 37280e4 into apache:master May 15, 2020
@leezu leezu deleted the fixdc branch May 16, 2020 01:00
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
@leezu @AntiZpvoh
Fix deferred compute mode for operators using new FFI (apache#18284)
338c21f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha szha approved these changes

@haojin2 haojin2 Awaiting requested review from haojin2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leezu @mxnet-bot @szha