Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Back port the PR #17672:boolean indexing to branch v1.x #18351

Merged
merged 1 commit into from
May 28, 2020

Conversation

Alicia1529
Copy link
Contributor

Description

Back port the PR #17672:boolean indexing from master to branch v1.x
@ciyongch

@Alicia1529 Alicia1529 requested a review from szha as a code owner May 18, 2020 11:48
@mxnet-bot
Copy link

Hey @Alicia1529 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, edge, centos-cpu, unix-gpu, sanity, miscellaneous, windows-gpu, unix-cpu, website, clang, windows-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ciyongch
Copy link
Contributor

@Alicia1529 , please help to re-trigger the failed CI, thanks!

@Alicia1529
Copy link
Contributor Author

@mxnet-bot run ci [website, clang, edge, miscellaneous, unix-cpu, unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [website, miscellaneous, clang, unix-cpu, unix-gpu, edge]

@Alicia1529
Copy link
Contributor Author

@mxnet-bot run ci [edge, unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu, edge]

@Alicia1529
Copy link
Contributor Author

@mxnet-bot run ci [edge]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [edge]

@Alicia1529
Copy link
Contributor Author

@mxnet-bot run ci [edge]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [edge]

@Alicia1529
Copy link
Contributor Author

@mxnet-bot run ci [edge]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [edge]

@Alicia1529
Copy link
Contributor Author

@mxnet-bot run ci [edge]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [edge]

@Alicia1529
Copy link
Contributor Author

@mxnet-bot run ci [edge]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [edge]

@Alicia1529
Copy link
Contributor Author

@mxnet-bot run ci [edge]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [edge]

@Alicia1529
Copy link
Contributor Author

@mxnet-bot run ci [edge]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [edge]

@Alicia1529
Copy link
Contributor Author

@mxnet-bot run ci [edge]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [edge]

@Alicia1529
Copy link
Contributor Author

Hi @ciyongch, I've retriggered the test [edge] for several times. Can we consider tweak the tolerance a little bit?

@ciyongch
Copy link
Contributor

Hi @Alicia1529 , there's a PR #18339 targeting to fix the failed CI edge job, let's hold on for a while and retry when it's get merged. Thanks.

@ciyongch
Copy link
Contributor

Hi @Alicia1529 , #18375 which fixed the edge CI failure was merged in v1.x branch, please help to re-trigger the edge job, which should be passed now. Thanks.

@Alicia1529
Copy link
Contributor Author

@mxnet-bot run ci [edge]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [edge]

@Alicia1529
Copy link
Contributor Author

Hi @ciyongch, this pr has passed all the tests and is ready to be merged.

@ciyongch
Copy link
Contributor

Thanks @Alicia1529 , we get all the CI tests passed finally :)
@TaoLv @pengzhao-intel @leezu please help to take a look and merge it.

@TaoLv TaoLv merged commit 0c6785f into apache:v1.x May 28, 2020
ChaiBapchya pushed a commit to ChaiBapchya/mxnet that referenced this pull request Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants