This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Get rid of monkey patching in LossScaler overflow handling #18959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mk-61 , Thanks for submitting the PR
CI supported jobs: [centos-cpu, clang, centos-gpu, unix-gpu, edge, miscellaneous, sanity, unix-cpu, windows-gpu, website, windows-cpu] Note: |
|
@mxnet-bot run ci [windows-gpu] |
|
Jenkins CI successfully triggered : [windows-gpu] |
|
@mxnet-bot run ci [unix-cpu] |
|
Jenkins CI successfully triggered : [unix-cpu] |
mk-61
added a commit
to mk-61/incubator-mxnet
that referenced
this pull request
Aug 20, 2020
) Co-authored-by: Vladimir Cherepanov <[email protected]>
ptrendx
pushed a commit
that referenced
this pull request
Aug 24, 2020
…18973) Co-authored-by: Vladimir Cherepanov <[email protected]> Co-authored-by: Vladimir Cherepanov <[email protected]>
chinakook
pushed a commit
to chinakook/mxnet
that referenced
this pull request
Aug 11, 2021
) Co-authored-by: Vladimir Cherepanov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current overflow checking in AMP LossScaler uses monkey patching and closures, which doesn't mix well with pickling, causing #16858. This change implements similar logic without monkey patching.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
@ptrendx