This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
FwdPort of "1.x-Backport Add cmake flag USE_FATBIN_COMPRESSION, ON by default (#19123) (#19158)" #19175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pache#19123) (apache#19158) * [1.x] Backport Add cmake flag USE_FATBIN_COMPRESSION, ON by default (apache#19123) * Trigger CI * Appending to existing CMAKE_CUDA_FLAGS in all cases
|
Hey @DickJC123 , Thanks for submitting the PR
CI supported jobs: [windows-gpu, windows-cpu, clang, centos-gpu, miscellaneous, unix-cpu, edge, website, centos-cpu, unix-gpu, sanity] Note: |
|
@mxnet-bot run ci [centos-cpu] |
|
Jenkins CI successfully triggered : [centos-cpu] |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the 1.x backporting of master-branch PR #19123 (as PR #19158), some issues were discovered and corrected. This PR "forward ports" the result so that the logic behind use of fatbin compression remains consistent between master and v1.x.
Currently, master has the following issues:
If CMAKE_CUDA_FLAGS were already set, to say "--foo=bar", then that env var would be altered incorrectly to "--foo=bar--fatbin-options -compress-all"
Also, if USE_SPLIT_ARCH_DLL=OFF and MSVC=1, there would be no fatbin compression, even with USE_FATBIN_COMPRESSION=ON.
This PR corrects these issues, and so makes master behave like v1.x.