Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Define NVML_NO_UNVERSIONED_FUNC_DEFS #20146

Merged
merged 3 commits into from
Apr 12, 2021
Merged

Define NVML_NO_UNVERSIONED_FUNC_DEFS #20146

merged 3 commits into from
Apr 12, 2021

Conversation

Zha0q1
Copy link
Contributor

@Zha0q1 Zha0q1 commented Apr 8, 2021

fixes #20145

@Zha0q1 Zha0q1 requested review from leezu and szha as code owners April 8, 2021 22:42
@mxnet-bot
Copy link

Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, clang, website, centos-gpu, unix-gpu, miscellaneous, unix-cpu, sanity, edge, windows-cpu, windows-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 8, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 8, 2021
@Zha0q1
Copy link
Contributor Author

Zha0q1 commented Apr 9, 2021

@mxnet-bot run ci [all]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu, unix-cpu, website, edge, sanity, unix-gpu, centos-gpu, centos-cpu, clang, miscellaneous, windows-cpu]

@Zha0q1
Copy link
Contributor Author

Zha0q1 commented Apr 9, 2021

@mxnet-bot run ci [all]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [edge, windows-cpu, miscellaneous, unix-gpu, windows-gpu, website, sanity, unix-cpu, centos-gpu, clang, centos-cpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 9, 2021
@lanking520 lanking520 removed the pr-work-in-progress PR is still work in progress label Apr 11, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Apr 11, 2021
waytrue17
waytrue17 approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@waytrue17 waytrue17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Zha0q1 Zha0q1 changed the title [wip] Define NVML_NO_UNVERSIONED_FUNC_DEFS Define NVML_NO_UNVERSIONED_FUNC_DEFS Apr 12, 2021
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Apr 12, 2021
leezu
leezu reviewed Apr 12, 2021
View reviewed changes
CMakeLists.txt
if(USE_NVML)
find_package(NVML)
if(NVML_FOUND)
target_compile_definitions(mxnet PRIVATE NVML_NO_UNVERSIONED_FUNC_DEFS)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about moving this to line 595 above and avoid duplication of the nested ifs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add this compile def after https://github.com/apache/incubator-mxnet/blob/2cd1b4666d4e6d5df20bc139012061ef0d2e1a37/CMakeLists.txt#L656-L660. In fact I tried what you suggested and got into this error

[2021-04-08T23:00:06.226Z] CMake Error at CMakeLists.txt:600 (target_compile_definitions):

[2021-04-08T23:00:06.226Z]   Cannot specify compile definitions for target "mxnet" which is not built by

[2021-04-08T23:00:06.226Z]   this project.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. So you can consider add it after line 660, or move 656-660 to an earlier location in the file. It's not necessary to do it now.

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Apr 12, 2021
@lanking520 lanking520 added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 12, 2021
@Zha0q1 Zha0q1 merged commit e204dad into apache:master Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leezu leezu leezu approved these changes

@waytrue17 waytrue17 waytrue17 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MXNet 2.0 cu112 docker undefined symbol issue
5 participants
@Zha0q1 @mxnet-bot @leezu @waytrue17 @lanking520