This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[BUGFIX] Fix issue with LogMessageFatal #20848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two different versions of the LogMessageFatal class in the same namespace in different files so depending on order of compilation it sometimes cause mixing it and segmentation fault (probably due to mixing versions of constructor/destructor (one inlined and one linked))
|
Hey @anko-intel , Thanks for submitting the PR
CI supported jobs: [edge, unix-cpu, windows-gpu, miscellaneous, website, centos-gpu, windows-cpu, sanity, unix-gpu, centos-cpu, clang] Note: |
mseth10
added
the
pr-awaiting-testing
bartekkuncer
approved these changes
Jan 26, 2022
mozga-intel
reviewed
Jan 26, 2022
mseth10
added
pr-work-in-progress
3rdparty/mshadow is no git module any longer. The other words it is not real 3rparty now |
|
@mxnet-bot run ci [centos-gpu, centos-cpu] |
|
Jenkins CI successfully triggered : [centos-cpu, centos-gpu] |
mseth10
added
pr-awaiting-testing
mseth10
added
pr-awaiting-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were two different versions of the LogMessageFatal class in the
same namespace in different files so depending on order of compilation
it sometimes cause mixing it and segmentation fault (probably due to
mixing versions of constructor/destructor (one inlined and one linked))
It is connected with the issue reported on v1.x branch: #20827
Checklist
Essentials