Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

replace has_key by in #8317

Merged
merged 3 commits into from
Nov 19, 2017
Merged

replace has_key by in #8317

merged 3 commits into from
Nov 19, 2017

Conversation

chihming
Copy link
Contributor

@chihming chihming commented Oct 17, 2017

Description

This issue is the same as #2037, #2038, #2668, but there still exists codes using has_key() function which has been removed in Python3.x. Please have a check.

Checklist

Essentials

  • Passed code style checking (make lint)
    All passed!
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • For user-facing API changes, API doc string has been updated.
  • To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • replace has_key function by in method

Comments

  • None

@eric-haibin-lin
Copy link
Member

Do you mind sync with master and trigger CI again?

@piiswrong piiswrong merged commit 7f7e13d into apache:master Nov 19, 2017
eric-haibin-lin pushed a commit to eric-haibin-lin/mxnet that referenced this pull request Dec 3, 2017
* replace `has_key` by `in`

* Update utils.py
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
* replace `has_key` by `in`

* Update utils.py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants