This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piiswrong
reviewed
Nov 22, 2017
src/io/image_io.cc
Outdated
@@ -156,7 +156,10 @@ void ImdecodeImpl(int flag, bool to_rgb, void* data, size_t size, | |||
} else { | |||
dst = cv::Mat(out->shape()[0], out->shape()[1], flag == 0 ? CV_8U : CV_8UC3, | |||
out->data().dptr_); | |||
#if (CV_MAJOR_VERSION > 2 || (CV_MAJOR_VERSION == 2 && CV_MINOR_VERSION >=4)) | |||
#if (CV_MAJOR_VERSION > 2 && CV_MINOR_VERSION >= 3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition won't work for opencv 4.1
you should use CV_MAJOR_VERSION > 3 || (CV_MAJOR_VERSION == 3 && CV_MINOR_VERSION >=3)
eric-haibin-lin
pushed a commit
to eric-haibin-lin/mxnet
that referenced
this pull request
Dec 3, 2017
* fix image io for opencv3.3 * update function in cv_api * fix bug * fix lint
KellenSunderland
pushed a commit
to KellenSunderland/incubator-mxnet
that referenced
this pull request
Dec 3, 2017
* fix image io for opencv3.3 * update function in cv_api * fix bug * fix lint
zhreshold
pushed a commit
to zhreshold/mxnet
that referenced
this pull request
Dec 14, 2017
* fix image io for opencv3.3 * update function in cv_api * fix bug * fix lint
szha
pushed a commit
that referenced
this pull request
Dec 14, 2017
* fix image io for opencv3.3 * update function in cv_api * fix bug * fix lint
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
* fix image io for opencv3.3 * update function in cv_api * fix bug * fix lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting from OpenCV3.3 the
imdecode
function will automatically rotate the image based on the EXIF' orientation flag.This can be disabled by setting the
cv::IMREAD_IGNORE_ORIENTATION
flag.Checklist
Essentials
make lint
)Changes
IMREAD_IGNORE_ORIENTATION
flag when opencv 3.3 is used.Comments