This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
support regex of collect_params() #9348
Merged
+42
−6
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d3c9ee4
support regex of collect_params()
6294744
fix pylint
0f4fe1e
change default value && make select as a sigle reg
7d15253
fix if select is None, then will not do any regex matching
tornadomeet ac25025
update regex compile && add test
tornadomeet d565e6d
Update block.py
szha 1bcde15
support regex of collect_params()
dd28916
fix pylint
b4c9b0c
change default value && make select as a sigle reg
5712b52
fix if select is None, then will not do any regex matching
tornadomeet 818ce58
update regex compile && add test
tornadomeet 0cee605
Merge branch 'filter' of https://github.com/tornadomeet/mxnet into fi…
tornadomeet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix pylint
commit dd2891657fae7b3dd8be7a2eda8809e737ff5b82
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only support 1 regex, not a list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. @piiswrong
another, if user has a python list to select parameter, like ['a', 'b', 'c'], t hen he/she should first convert select='a|b|c' first using some code, any better way to avoid this?