image erase: allow only when slot image is not backup/pending... #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvlsianpu
force-pushed
the
erase_if_swap_none
branch
from
a02aa0e to
d456e7a
Compare
|
Can you look at this @ccollins476ad @carlescufi |
|
I think you should be returning |
It was possible to erase slot 1 while it stores confirmed image while ongoing test run - this is unwanted behavior which allow to even brick remote device accidentally. This patch add check for such case of test run etc. This also aligns condition required for erase command execution to similar as upload command requires. Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
force-pushed
the
erase_if_swap_none
branch
from
d456e7a to
0b0d5a8
Compare
|
Changed. I think here: |
|
I think the second one actually makes a little sense semantically, because if there is no available slot it could be "no mem", but erasing "no mem" would be weirder, so makes more sense to say it cannot erase because of a bad state. |
utzig
approved these changes
Sep 10, 2018
sjanc
approved these changes
Oct 3, 2018
|
@utzig merge? |
mlaz
pushed a commit
to mlaz/mynewt-mcumgr
that referenced
this pull request
Oct 2, 2019
Closing CBOR containers on error situations before returning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible to erase slot 1 while it stores confirmed image
while ongoing test run - this is unwanted behavior which allow
to even brick remote device accidentally.
This patch add check for such case of test run etc.
This also aligns condition required for erase command
execution to similar as upload command requires.
Signed-off-by: Andrzej Puzdrowski [email protected]