Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mynewt port of mcumgr and various fixes #27

Merged
merged 72 commits into from
Oct 8, 2019
Merged

Update mynewt port of mcumgr and various fixes #27

merged 72 commits into from
Oct 8, 2019

Conversation

vrahane
Copy link
Contributor

@vrahane vrahane commented Jul 18, 2019 •
edited
Loading

  • Updating mynewt port of MCUmgr
  • Adding Stats, Logs, datetime and other default commands support to MCUmgr
  • Changing mgmt_group_register() in MCUmgr so that it allows re-registration of command groups
  • Please refer Port MCUmgr to mynewt-core and remove newtmgr support mynewt-core#1871 for more context
  • Fix dependency and build issues
  • Adding support for log version 3 and image hash changes
  • Adding support for image management lazy erase
  • Adding support for config mgmt
  • Updating cborattr to have similar support as mynewt-core
  • Get all features in sync with mynewt-core
  • Fix unit tests and add some more for cborattr
  • Change log_mgmt to use fragmenting so that an entry can be divided into smaller chunks while reading.
  • Fix mynewt port of os_mgmt
  • Add changes for backwards compatibility
  • Add sample app: omp_svr for trying out OICMGR over BLE/Serial
  • Fix reboot_log for soft resets
    Please refer Use SMP/OMP/MCUmgr, remove newtmgr and change OICMGR to use OMP  mynewt-core#1917 for corresponding mynewt-core changes.

@vrahane vrahane changed the title [WIP - DO NOT MERGE] Update mynewt port of mcumgr [WIP - DO NOT MERGE] Update mynewt port of mcumgr and various fixes Jul 18, 2019
@mlaz mlaz self-assigned this Jul 29, 2019
@vrahane vrahane self-assigned this Jul 31, 2019
@vrahane vrahane mentioned this pull request Sep 11, 2019
Merged
@vrahane vrahane changed the title [WIP - DO NOT MERGE] Update mynewt port of mcumgr and various fixes Update mynewt port of mcumgr and various fixes Sep 27, 2019
@vrahane vrahane mentioned this pull request Sep 27, 2019
Merged
vrahane and others added 18 commits September 27, 2019 17:50
@vrahane
mynewt core mcumgr port
97241e2
@vrahane
Custome reader/writer only used for ZEPHYR
682df33
@vrahane
Mynewt: Fix Apache Mynewt MCUmgr nuild issues
43a2a81
@vrahane
Remove stubs - were causing build issues since the packpages are sepa…
0a3fbb0 
…rate for mynewt port
@vrahane
Fix build issues
6e4556a
@vrahane
Fix build issues
97c6ecd
@vrahane
Add img_mgmt pkg_init
8aec843
@vrahane
cmd/os_mgmt: Fix mynewt port and misc fixes
adb281c
@vrahane
log_mgmt: Add fixes from mynewt-core to log_mgmt
06ecd3b 
- Make sure it builds and works
- Make stat_mgmt buildable
- Some fixes to img_mgmt
@vrahane
log_mgmt: log entry encoder needs to be generic
69f7d69
@vrahane
Fix a few bugs with log read handlers
a0d3a96
@vrahane
SMP: make multiple registration for same group possible
a29e222
@vrahane
stat_mgmt: Add stat_mgmt support for mynewt
5d72448
@vrahane
img_mgmt: Make img_mgmt_slot_in_use() a public API
6496426
@mlaz @vrahane
Added lazy erase support.
675e39b
@mlaz @vrahane
Fix soft reset logging
7f034c4
@vrahane
img_mgmt: Mynewt port update
8914f87 
- Update mynewt port wrt features from mynewt-core
- For flash functions define 'impl' functions
- Make sure everything builds
@vrahane
img_mgmt: Fix build
724c256
@vrahane vrahane mentioned this pull request Oct 1, 2019
Merged
@vrahane
Merge pull request #11 from mlaz/mynewt_mcumgr
b20765b 
Closing CBOR containers on error situations before returning.
mkiiskila
mkiiskila reviewed Oct 1, 2019
View reviewed changes
cborattr/src/cborattr.c Show resolved Hide resolved
cmd/img_mgmt/include/img_mgmt/img_mgmt.h Outdated Show resolved Hide resolved
cmd/img_mgmt/include/img_mgmt/img_mgmt.h Outdated Show resolved Hide resolved
cmd/img_mgmt/include/img_mgmt/img_mgmt.h Outdated Show resolved Hide resolved
cmd/img_mgmt/include/img_mgmt/img_mgmt_impl.h Outdated Show resolved Hide resolved
cmd/log_mgmt/port/mynewt/src/mynewt_log_mgmt.c Outdated Show resolved Hide resolved
cmd/log_mgmt/src/log_mgmt.c Outdated Show resolved Hide resolved
cmd/stat_mgmt/pkg.yml Outdated Show resolved Hide resolved
cmd/stat_mgmt/port/mynewt/src/mynewt_stat_mgmt.c Outdated Show resolved Hide resolved
util/pkg.yml Outdated Show resolved Hide resolved
vrahane and others added 5 commits October 1, 2019 14:33
@vrahane
log_mgmt: Add watermark support
d6a7bcb
@vrahane
log_mgmt: entries need to be encoded chunk by chunk
a6adcb2 
- entries were encoded together earlier which caused issues, encoding
them chunk by chunk fixes it.
@vrahane
log_mgmt: add some comments
59576c1
@mlaz
cmd/fs fixing package dependency chain
081cad7
@vrahane
cmd: move config headers to include directory
8478dcb 
- Move config headers to include directory and general clean up
  and address review comments
@vrahane
Copy link
Contributor Author

vrahane commented Oct 2, 2019

@mkiiskila I made changes as per your review comments, thanks.

vrahane and others added 3 commits October 2, 2019 14:47
@vrahane
cborattr: APIs & structs need to be MYNEWT specific
bde1003 
- mbuf APIs and structs containing mbuf ptrs need to be
  MYNEWT specific
@vrahane
img_mgmt: coding style changes
ebf9d6e
@vrahane
Merge pull request #12 from mlaz/mynewt_mcumgr
50e8571 
cmd/fs fixing package dependency chain
@mlaz mlaz mentioned this pull request Oct 4, 2019
Open
@nvlsianpu
Copy link
Contributor

@de-nordic Pleas review

mkiiskila
mkiiskila approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@mkiiskila mkiiskila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrahane vrahane merged commit 3555086 into apache:master Oct 8, 2019
@carlescufi
Copy link
Contributor

This completely broke the Zephyr port @vrahane and @mkiiskila. We did not have time to react quickly enough, but I think we should strive for changes that are posted as a PR here to be tested on both Mynewt and Zephyr, since this is a cross-RTOS open source project.
Can we have a talk about this and avoid this situation again?

@vrahane
Copy link
Contributor Author

vrahane commented Oct 14, 2019

@carlescufi Sure, we can have a chat about it. The work is not yet over, we will be making more changes to get the zephyr side working. @mlaz is working on getting the samples to work.

@carlescufi
Copy link
Contributor

carlescufi commented Oct 15, 2019 •
edited
Loading

@carlescufi Sure, we can have a chat about it. The work is not yet over, we will be making more changes to get the zephyr side working. @mlaz is working on getting the samples to work.

Thanks @vrahane. I think we need to sync up because @de-nordic and @nvlsianpu are also working on the same changes.

@de-nordic
Copy link
Contributor

Pasting my comment from #mcumgr channel here:
basically it is no longer possible to compile/link mcumgr library within zephyr due to changes in mcumgr/cmd/img_mgmt/img_mgmt.c . There has been some impactful changes to this common code, that have been backed by changes in port/mynewt but at the same time port/zephyr has not been altered to provide missing functions. For example: img_mgmt_upload relies on img_mgmt_impl_upload_inspect which is now missing from port/zephyr implementation.

@de-nordic
Copy link
Contributor

Right now I am at the stage when code compiles but does not link. I have paused in working on implementing missing functions and now I wait to sync up with you to avoid redundancy in work effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkiiskila mkiiskila mkiiskila approved these changes

Assignees

@mlaz mlaz

@vrahane vrahane

Labels
BLE IMG_MGMT LOGS SERIAL SMP STATS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vrahane @nvlsianpu @carlescufi @de-nordic @mkiiskila @mlaz