Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zephyr smp_svr build testing to Travis-CI #63

Closed
wants to merge 1 commit into from

Conversation

utzig
Copy link
Member

@utzig utzig commented Jan 29, 2020

This builds smp_svr directly from the Zephyr tree; the purpose is to assure that the provided sample is still in a good build state when the mcumgr code changes.

@utzig utzig force-pushed the enable-travis branch 6 times, most recently from 40d3a25 to 187f443 Compare January 30, 2020 11:48
@utzig utzig force-pushed the enable-travis branch 4 times, most recently from 0221ec0 to ec76a2e Compare January 30, 2020 15:54
@utzig utzig changed the title [DNM] Add travis test script Add Zephyr smp_svr build testing to Travis-CI Jan 30, 2020
@utzig utzig marked this pull request as ready for review January 30, 2020 16:21
@utzig
Copy link
Member Author

utzig commented Jan 30, 2020

This takes an approach as suggested by #60 (comment). Instead of having multiple copies that need to be constantly synchronized (Possible losing commit history), allow the sample to live outside the tree and check that it is in a build state here.

Would be easy to add Mynewt build testing as well, so maybe, smp_svr for Mynewt could live in the core repo (eg apps/smp_svr) and we could leave here just a non-functional sample with OS specific stuff as "to implement" comments or something similar.

There are no tests running as of now, only building the app!

/cc @vrahane @mlaz @nvlsianpu @carlescufi @de-nordic

@utzig
Copy link
Member Author

utzig commented Jan 31, 2020

Well, no comments so I am assuming this was not a good idea. I will add reviewers because it might still be considered helpful to have this build on CI, otherwise feel free to close the PR and let's move on with #60 or #62.

@utzig utzig requested review from vrahane and mlaz January 31, 2020 15:37
@vrahane
Copy link
Contributor

vrahane commented Jan 31, 2020

Hi @utzig we haven’t closed the loop yet on whether we will keep the smp_svr in mcumgr upstream for zephyr as is or just keep the zephyr version of it. So, I would suggest adding builds for both the zephyr version as well as the upstream version for now atleast until we come to a consensus.

Copy link
Contributor

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very skeptical of this. It is not going to be possible to maintain master:master compatibility between this repo and zephyrproject-rtos/zephyr, there is gonna be failures.

export ZEPHYR_SDK_INSTALL_DIR="${HOME}/zephyr-sdk"

repos=(
"https://github.com/zephyrproject-rtos/zephyr"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are going to use Zephyr, you really should use west to pull down the repos. How else are you going to be sure that you are pulling the right set?

@utzig utzig closed this Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants