MINIFICPP-1809: custom Cron(quartz syntax) implementation and cron tests #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgerlits
reviewed
May 26, 2022
fgerlits
reviewed
May 31, 2022
lordgamez
approved these changes
Jun 1, 2022
libminifi/include/utils/Cron.h
Outdated
|
|
||
| [[nodiscard]] std::optional<date::local_seconds> calculateNextTrigger(date::local_seconds start) const; | ||
|
|
||
| std::unique_ptr<CronField> second_, minute_, hour_, day_, month_, day_of_week_, year_; |
There was a problem hiding this comment.
It may be better only declaring one member per line as per suggested by the core guidelines
There was a problem hiding this comment.
good idea, I've changed it in 474cb15
libminifi/src/utils/Cron.cpp
Outdated
| using date::from_stream; | ||
| using date::make_time; | ||
|
|
||
| using date::Friday; using date::Saturday; using date::Sunday; |
There was a problem hiding this comment.
nitpick: as they are only used once, I'm not sure it's necessary to use using here, also if you do it would be more readable in separate lines
There was a problem hiding this comment.
I wanted to list clearly what are we using from date and what from std::chrono.
But I agree its more readable to separate them. 474cb15
fgerlits
approved these changes
Jun 2, 2022
szaszm
reviewed
Jun 3, 2022
szaszm
reviewed
Jun 7, 2022
szaszm
reviewed
Jun 8, 2022
adamdebreceni
approved these changes
Jun 8, 2022
Co-authored-by: Ferenc Gerlits <[email protected]>
added explanation for dateSetInstall
szaszm
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.