NIFI-14140 Applied PMD's UnusedLocalVariable across the code base and…

… fixed all the violations.

minifi/minifi-toolkit/minifi-toolkit-schema/src/main/java/org/apache/nifi/minifi/toolkit/schema/ConfigSchema.java

@@ -115,7 +115,6 @@ public ConfigSchema(Map map, List<String> validationIssues) {
         List<String> allControllerServiceIds = allProcessGroups.stream().flatMap(p -> p.getControllerServices().stream()).map(ControllerServiceSchema::getId).collect(Collectors.toList());
         List<String> allFunnelIds = allProcessGroups.stream().flatMap(p -> p.getFunnels().stream()).map(FunnelSchema::getId).collect(Collectors.toList());
         List<String> allConnectionIds = allConnectionSchemas.stream().map(ConnectionSchema::getId).collect(Collectors.toList());
-        List<String> allRemoteProcessGroupNames = allRemoteProcessGroups.stream().map(RemoteProcessGroupSchema::getName).collect(Collectors.toList());
         List<String> allRemoteInputPortIds = allRemoteProcessGroups.stream().filter(r -> r.getInputPorts() != null)
                 .flatMap(r -> r.getInputPorts().stream()).map(RemotePortSchema::getId).collect(Collectors.toList());
         List<String> allRemoteOutputPortIds = allRemoteProcessGroups.stream().filter(r -> r.getOutputPorts() != null)

nifi-commons/nifi-properties/src/test/java/org/apache/nifi/util/NiFiPropertiesTest.java

@@ -188,7 +188,7 @@ public void testShouldVerifyExceptionThrownWhenInValidFormatPortValue() {
         NiFiProperties properties = loadNiFiProperties("/NiFiProperties/conf/nifi.blank.properties", additionalProperties);
 
         // Act
-        Integer clusterProtocolPort = properties.getClusterNodeProtocolPort();
+        properties.getClusterNodeProtocolPort();
         assertThrows(NumberFormatException.class, () -> Integer.parseInt(portValue));
     }
 

nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/s3/TestDeleteS3Object.java

@@ -100,7 +100,6 @@ public void testDeleteObjectS3Exception() {
         runner.run(1);
 
         runner.assertAllFlowFilesTransferred(DeleteS3Object.REL_FAILURE, 1);
-        ArgumentCaptor<DeleteObjectRequest> captureRequest = ArgumentCaptor.forClass(DeleteObjectRequest.class);
         Mockito.verify(mockS3Client, Mockito.never()).deleteVersion(Mockito.any(DeleteVersionRequest.class));
     }
 

nifi-extension-bundles/nifi-evtx-bundle/nifi-evtx-processors/src/main/java/org/apache/nifi/processors/evtx/parser/bxml/value/SystemtimeTypeNode.java

@@ -38,7 +38,7 @@ public SystemtimeTypeNode(BinaryReader binaryReader, ChunkHeader chunkHeader, Bx
         int year = binaryReader.readWord();
         int month = binaryReader.readWord();
         final int monthOfYear = month + 1;
-        int dayOfWeek = binaryReader.readWord();
+        binaryReader.readWord(); // dayOfWeek
         int day = binaryReader.readWord();
         int hour = binaryReader.readWord();
         int minute = binaryReader.readWord();

nifi-extension-bundles/nifi-extension-utils/nifi-dbcp-base/src/main/java/org/apache/nifi/dbcp/AbstractDBCPConnectionPool.java

@@ -86,7 +86,7 @@ public List<ConfigVerificationResult> verify(final ConfigurationContext context,
                     .explanation("Successfully configured data source")
                     .build());
 
-            try (final Connection conn = getConnection(basicDataSource, kerberosUser)) {
+            try (final Connection ignored = getConnection(basicDataSource, kerberosUser)) {
                 results.add(new ConfigVerificationResult.Builder()
                         .verificationStepName("Establish Connection")
                         .outcome(SUCCESSFUL)

nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/storage/ListGCSBucketTest.java

@@ -769,7 +769,6 @@ public void testFileAcls() {
 
     @Test
     public void testYieldOnBadStateRestore() {
-        final Iterable<Blob> mockList = Collections.emptyList();
 
         runner.getStateManager().setFailOnStateGet(Scope.CLUSTER, true);
         runner.enqueue("test");

nifi-extension-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/FlowFileStreamUnpackerSequenceFileWriter.java

@@ -41,7 +41,7 @@ public class FlowFileStreamUnpackerSequenceFileWriter extends SequenceFileWriter
     @Override
     protected void processInputStream(final InputStream stream, final FlowFile flowFileStreamPackedFlowFile, final Writer writer) throws IOException {
         final FlowFileUnpackager unpackager = new FlowFileUnpackager();
-        try (final InputStream in = new BufferedInputStream(stream)) {
+        try (final InputStream ignored = new BufferedInputStream(stream)) {
             while (unpackager.hasMoreData()) {
                 unpackager.unpackageFlowFile(stream, writer);
             }

nifi-extension-bundles/nifi-hazelcast-bundle/nifi-hazelcast-services/src/main/java/org/apache/nifi/hazelcast/services/cacheclient/HazelcastMapCacheClient.java

@@ -139,7 +139,7 @@ public <K, V> boolean replace(final AtomicCacheEntry<K, V, Long> entry, final Se
 
         final String key = serializeCacheEntryKey(entry.getKey(), keySerializer);
 
-        try (final HazelcastCache.HazelcastCacheEntryLock lock = cache.acquireLock(key)) {
+        try (final HazelcastCache.HazelcastCacheEntryLock ignored = cache.acquireLock(key)) {
             final byte[] oldValue = cache.get(key);
 
             if (oldValue == null && (entry.getRevision().isEmpty() || entry.getRevision().get() < STARTING_REVISION)) {

nifi-extension-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/kafka/processors/ConsumeKafka.java

@@ -330,7 +330,6 @@ public void onPropertyModified(final PropertyDescriptor descriptor, final String
 
     @OnScheduled
     public void onScheduled(final ProcessContext context) {
-        final KafkaConnectionService connectionService = context.getProperty(CONNECTION_SERVICE).asControllerService(KafkaConnectionService.class);
         pollingContext = createPollingContext(context);
         headerEncoding = Charset.forName(context.getProperty(HEADER_ENCODING).getValue());
 

nifi-extension-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/java/org/apache/nifi/processors/script/TestScriptedTransformRecord.java

@@ -134,6 +134,7 @@ public void testZeroRecordInput() throws InitializationException {
         assertEquals(0, testRunner.getCounterValue("Records Dropped").intValue());
 
         final List<Record> written = recordWriter.getRecordsWritten();
+        assertEquals(0, written.size());
     }
 
     @Test

nifi-extension-bundles/nifi-smb-bundle/nifi-smb-smbj-client/src/test/java/org/apache/nifi/services/smb/SmbjClientServiceIT.java

@@ -26,7 +26,6 @@
 import static org.apache.nifi.smb.common.SmbProperties.TIMEOUT;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.junit.jupiter.api.Assertions.fail;
-import static org.mockito.Mockito.mock;
 
 import eu.rekawek.toxiproxy.model.ToxicDirection;
 import java.util.HashMap;
@@ -38,7 +37,6 @@
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicInteger;
 import org.apache.nifi.components.PropertyDescriptor;
-import org.apache.nifi.controller.ConfigurationContext;
 import org.apache.nifi.util.MockConfigurationContext;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
@@ -94,7 +92,6 @@ public void shouldRescueAfterConnectionFailure() throws Exception {
         writeFile("testDirectory/directory2/nested_directory/file", "content");
         ContainerProxy sambaProxy = toxiproxy.getProxy("samba", 445);
         SmbjClientProviderService smbjClientProviderService = new SmbjClientProviderService();
-        ConfigurationContext context = mock(ConfigurationContext.class);
 
         Map<PropertyDescriptor, String> properties = new HashMap<>();
         properties.put(HOSTNAME, sambaProxy.getContainerIpAddress());

nifi-extension-bundles/nifi-standard-bundle/nifi-standard-parameter-providers/src/main/java/org/apache/nifi/parameter/KubernetesSecretParameterProvider.java

@@ -148,7 +148,6 @@ public List<ConfigVerificationResult> verify(final ConfigurationContext context,
 
         try {
             final List<ParameterGroup> parameterGroups = fetchParameters(context);
-            final Set<String> parameterGroupNames = parameterGroups.stream().map(ParameterGroup::getGroupName).collect(Collectors.toSet());
             final long parameterCount = parameterGroups.stream()
                     .flatMap(group -> group.getParameters().stream())
                     .count();

nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ReplaceText.java

@@ -717,7 +717,6 @@ public FlowFile replace(FlowFile flowFile, final ProcessSession session, final P
                     out.write(updatedValue.getBytes(charset));
                 });
             } else {
-                final Pattern searchPattern = Pattern.compile(searchValue, Pattern.LITERAL);
 
                 flowFile = session.write(flowFile, new StreamReplaceCallback(charset, maxBufferSize, context.getProperty(LINE_BY_LINE_EVALUATION_MODE).getValue(),
                     (bw, oneLine) -> {

nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/PutDatabaseRecordTest.java

@@ -255,8 +255,6 @@ public void testSetAutoCommitFalseFailure() throws InitializationException, SQLE
 
         LocalDate testDate1 = LocalDate.of(2021, 1, 26);
         Date jdbcDate1 = Date.valueOf(testDate1); // in local TZ
-        LocalDate testDate2 = LocalDate.of(2021, 7, 26);
-        Date jdbcDate2 = Date.valueOf(testDate2); // in local TZ
 
         parser.addRecord(1, "rec1", 101, jdbcDate1);
 
@@ -1221,7 +1219,6 @@ public void testUpdateMultipleSchemas(TestCase testCase) throws InitializationEx
         runner.setProperty(PutDatabaseRecord.TABLE_NAME, "PERSONS");
 
         // Set some existing records with different values for name and code
-        Exception e;
         ResultSet rs;
 
         stmt.execute("INSERT INTO SCHEMA1.PERSONS VALUES (1,'x1',101,null)");
@@ -1715,14 +1712,6 @@ public void testInsertWithDefaultMaxBatchSize() throws InitializationException,
     public void testGenerateTableName() throws InitializationException, ProcessException {
         setRunner(TestCaseEnum.DEFAULT_0.getTestCase());
 
-        final List<RecordField> fields = Arrays.asList(new RecordField("id", RecordFieldType.INT.getDataType()),
-                new RecordField("name", RecordFieldType.STRING.getDataType()),
-                new RecordField("code", RecordFieldType.INT.getDataType()),
-                new RecordField("non_existing", RecordFieldType.BOOLEAN.getDataType())
-        );
-
-        final RecordSchema schema = new SimpleRecordSchema(fields);
-
         final TableSchema tableSchema = new TableSchema(
                 null,
                 null,
@@ -1831,9 +1820,6 @@ public void testInsertMismatchedNotCompatibleDataTypes() throws InitializationEx
         parser.addSchemaField("code", RecordFieldType.INT);
         parser.addSchemaField("dt", RecordFieldType.ARRAY.getArrayDataType(RecordFieldType.FLOAT.getDataType()).getFieldType());
 
-        LocalDate testDate1 = LocalDate.of(2021, 1, 26);
-        LocalDate testDate2 = LocalDate.of(2021, 7, 26);
-
         parser.addRecord("1", "rec1", 101, Arrays.asList(1.0, 2.0));
         parser.addRecord("2", "rec2", 102, Arrays.asList(3.0, 4.0));
         parser.addRecord("3", "rec3", 103, null);

nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/QueryDatabaseTableTest.java

@@ -1104,7 +1104,6 @@ public void testInitialLoadStrategyStartAtCurrentMaximumValues() throws SQLExcep
         // load test data to database
         final Connection con = ((DBCPService) runner.getControllerService("dbcp")).getConnection();
         Statement stmt = con.createStatement();
-        InputStream in;
 
         try {
             stmt.execute("drop table TEST_QUERY_DB_TABLE");

nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExecuteSQLRecord.java

@@ -563,7 +563,6 @@ public void invokeOnTriggerRecords(final Integer queryTimeout, final String quer
 
         // ResultSet size will be 1x200x100 = 20 000 rows
         // because of where PER.ID = ${person.id}
-        final int nrOfRows = 20000;
 
         MockRecordWriter recordWriter = new MockRecordWriter(null, true, -1);
         runner.addControllerService("writer", recordWriter);

nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExtractTextNamedGroups.java

@@ -48,7 +48,6 @@ public void testProcessor() {
 
         testRunner.assertAllFlowFilesTransferred(ExtractText.REL_MATCH, 1);
         final MockFlowFile out = testRunner.getFlowFilesForRelationship(ExtractText.REL_MATCH).get(0);
-        java.util.Map<String, String> attributes = out.getAttributes();
         out.assertAttributeEquals("regex.result1.ALL", SAMPLE_STRING);
         out.assertAttributeEquals("regex.result2.BAR1", "bar1");
         out.assertAttributeEquals("regex.result3.BAR1", "bar1");

nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestGetFile.java

@@ -141,19 +141,16 @@ public void testAttributes() throws IOException {
         final Path targetPath = destFile.toPath();
         Files.copy(inPath, targetPath);
 
-        boolean verifyLastModified = false;
         try {
             destFile.setLastModified(1000000000);
-            verifyLastModified = true;
-        } catch (Exception doNothing) {
+        } catch (Exception ignored) {
         }
 
         final TestRunner runner = TestRunners.newTestRunner(new GetFile());
         runner.setProperty(GetFile.DIRECTORY, "target/test/data/in");
         runner.run();
 
         runner.assertAllFlowFilesTransferred(GetFile.REL_SUCCESS, 1);
-        final List<MockFlowFile> successFiles = runner.getFlowFilesForRelationship(GetFile.REL_SUCCESS);
         //permissions are not verified as these are very environmentally specific
     }
 }

nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestListFile.java

@@ -140,7 +140,7 @@ private List<File> listFiles(final File file) {
     private void runNext() throws InterruptedException {
         runner.clearTransferState();
 
-        final List<File> files = listFiles(testDir);
+        listFiles(testDir);
         final Long lagMillis;
         if (isMillisecondSupported) {
             lagMillis = AbstractListProcessor.LISTING_LAG_MILLIS.get(TimeUnit.MILLISECONDS);

nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutTCP.java

@@ -352,7 +352,7 @@ private void assertMessagesReceived(final String[] sentData) throws Exception {
 
     private void assertMessagesReceived(final String[] sentData, final int iterations) throws Exception {
         for (int i = 0; i < iterations; i++) {
-            for (String item : sentData) {
+            for (String ignored : sentData) {
                 final ByteArrayMessage message = messages.take();
                 assertNotNull(message, String.format("Message [%d] not found", i));
                 assertTrue(Arrays.asList(sentData).contains(new String(message.getMessage())));

nifi-extension-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-hikari-dbcp-service/src/main/java/org/apache/nifi/dbcp/HikariCPConnectionPool.java

@@ -353,7 +353,7 @@ public List<ConfigVerificationResult> verify(final ConfigurationContext context,
                     .explanation("Successfully configured data source")
                     .build());
 
-            try (final Connection conn = getConnection(hikariDataSource, kerberosUser)) {
+            try (final Connection ignored = getConnection(hikariDataSource, kerberosUser)) {
                 results.add(new ConfigVerificationResult.Builder()
                         .verificationStepName("Establish Connection")
                         .outcome(SUCCESSFUL)

nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/json/TestInferJsonSchemaAccessStrategy.java

@@ -79,7 +79,7 @@ void testPerformanceOfSchemaInferenceWithTimestamp() throws IOException {
 
             for (int i = 0; i < 10_000; i++) {
                 try (final InputStream in = new ByteArrayInputStream(manyCopies)) {
-                    final RecordSchema schema = accessStrategy.getSchema(null, in, null);
+                    accessStrategy.getSchema(null, in, null);
                 }
             }
 
@@ -107,7 +107,7 @@ void testPerformanceOfSchemaInferenceWithoutTimestamp() throws IOException {
                     final InferSchemaAccessStrategy<?> accessStrategy = new InferSchemaAccessStrategy<>((var, content) -> new JsonRecordSource(content),
                             noTimestampInference, Mockito.mock(ComponentLog.class));
 
-                    final RecordSchema schema = accessStrategy.getSchema(null, in, null);
+                    accessStrategy.getSchema(null, in, null);
                 }
             }
 

nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml/TestInferXmlSchema.java

@@ -131,7 +131,6 @@ private RecordSchema inferSchema(final String filename, final String contentFiel
         final SchemaInferenceEngine<XmlNode> schemaInference = new XmlSchemaInference(timeValueInference);
         final InferSchemaAccessStrategy<XmlNode> inferStrategy = new InferSchemaAccessStrategy<>(xmlSourceFactory, schemaInference, Mockito.mock(ComponentLog.class));
 
-        final RecordSchema schema;
         try (final InputStream fis = new FileInputStream(file);
              final InputStream in = new BufferedInputStream(fis)) {
             return inferStrategy.getSchema(Collections.emptyMap(), in, null);

nifi-framework-api/src/test/java/org/apache/nifi/authorization/TestUser.java

@@ -27,8 +27,6 @@ public class TestUser {
     public void testSimpleCreation() {
         final String identifier = "1";
         final String identity = "user1";
-        final String group1 = "group1";
-        final String group2 = "group2";
 
         final User user = new User.Builder()
                 .identifier(identifier)
@@ -57,8 +55,6 @@ public void testMissingIdentity() {
     public void testFromUser() {
         final String identifier = "1";
         final String identity = "user1";
-        final String group1 = "group1";
-        final String group2 = "group2";
 
         final User user = new User.Builder()
                 .identifier(identifier)

nifi-framework-bundle/nifi-framework-extensions/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/toc/TestStandardTocWriter.java

@@ -32,7 +32,7 @@ public void testOverwriteEmptyFile() throws IOException {
         try {
             assertTrue(tocFile.createNewFile());
 
-            try (final StandardTocWriter writer = new StandardTocWriter(tocFile, false, false)) {
+            try (final StandardTocWriter ignored = new StandardTocWriter(tocFile, false, false)) {
             }
         } finally {
             FileUtils.deleteFile(tocFile, false);

nifi-framework-bundle/nifi-framework/nifi-authorizer/src/main/java/org/apache/nifi/authorization/AccessPolicyProviderInvocationHandler.java

@@ -42,7 +42,7 @@ public AccessPolicyProviderInvocationHandler(final AccessPolicyProvider accessPo
 
     @Override
     public Object invoke(final Object proxy, final Method method, final Object[] args) throws Throwable {
-        try (final NarCloseable narCloseable = NarCloseable.withComponentNarLoader(classLoader)) {
+        try (final NarCloseable ignored = NarCloseable.withComponentNarLoader(classLoader)) {
             if (getUserGroupProviderMethod.equals(method)) {
                 final UserGroupProvider userGroupProvider = (UserGroupProvider) method.invoke(accessPolicyProvider, args);
                 if (userGroupProvider == null) {

nifi-framework-bundle/nifi-framework/nifi-authorizer/src/main/java/org/apache/nifi/authorization/AuthorizerInvocationHandler.java

@@ -43,7 +43,7 @@ public AuthorizerInvocationHandler(final Authorizer authorizer, final ClassLoade
 
     @Override
     public Object invoke(final Object proxy, final Method method, final Object[] args) throws Throwable {
-        try (final NarCloseable narCloseable = NarCloseable.withComponentNarLoader(classLoader)) {
+        try (final NarCloseable ignored = NarCloseable.withComponentNarLoader(classLoader)) {
             if (getAccessPolicyProviderMethod.equals(method)) {
                 final AccessPolicyProvider accessPolicyProvider = (AccessPolicyProvider) method.invoke(authorizer, args);
                 if (accessPolicyProvider == null) {

nifi-framework-bundle/nifi-framework/nifi-authorizer/src/main/java/org/apache/nifi/authorization/UserGroupProviderInvocationHandler.java

@@ -34,7 +34,7 @@ public UserGroupProviderInvocationHandler(final UserGroupProvider userGroupProvi
 
     @Override
     public Object invoke(final Object proxy, final Method method, final Object[] args) throws Throwable {
-        try (final NarCloseable narCloseable = NarCloseable.withComponentNarLoader(classLoader)) {
+        try (final NarCloseable ignored = NarCloseable.withComponentNarLoader(classLoader)) {
             return method.invoke(userGroupProvider, args);
         } catch (final InvocationTargetException e) {
             // If the proxied instance throws an Exception, it'll be wrapped in an InvocationTargetException. We want

nifi-framework-bundle/nifi-framework/nifi-framework-cluster-protocol/src/test/java/org/apache/nifi/cluster/protocol/jaxb/message/TestJaxbProtocolUtils.java

@@ -74,7 +74,6 @@ public void testRoundTripConnectionResponse() throws JAXBException {
         JaxbProtocolUtils.JAXB_CONTEXT.createMarshaller().marshal(msg, baos);
         final Object unmarshalled = JaxbProtocolUtils.JAXB_CONTEXT.createUnmarshaller().unmarshal(new ByteArrayInputStream(baos.toByteArray()));
         assertTrue(unmarshalled instanceof ConnectionResponseMessage);
-        final ConnectionResponseMessage unmarshalledMsg = (ConnectionResponseMessage) unmarshalled;
 
         final ComponentRevisionSnapshot receivedSnapshot = msg.getConnectionResponse().getComponentRevisions();
         final List<ComponentRevision> revisions = receivedSnapshot.getComponentRevisions();

nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/test/java/org/apache/nifi/cluster/coordination/http/endpoints/TestProcessorEndpointMerger.java

@@ -34,7 +34,6 @@ public class TestProcessorEndpointMerger {
 
     @Test
     public void testMergeValidationErrors() {
-        final ProcessorEndpointMerger merger = new ProcessorEndpointMerger();
         final Map<String, Set<NodeIdentifier>> validationErrorMap = new HashMap<>();
 
         final NodeIdentifier nodeId1234 = new NodeIdentifier("1234", "localhost", 9000, "localhost", 9001, "localhost", 9002, 9003, false);

nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/test/java/org/apache/nifi/cluster/firewall/impl/FileBasedClusterNodeFirewallTest.java

@@ -58,9 +58,8 @@ public class FileBasedClusterNodeFirewallTest {
      */
     @BeforeAll
     public static void ensureBadHostsDoNotWork() {
-        final InetAddress ip;
         try {
-            ip = InetAddress.getByName(NONEXISTENT_HOSTNAME);
+            InetAddress.getByName(NONEXISTENT_HOSTNAME);
         } catch (final UnknownHostException uhe) {
             badHostsDoNotResolve = true;
         }