NIFI-14149 Fix invalid MiNiFi flow json by setting the default value of maxTimerDrivenThreadCount and update minifi-toolkit command set with examples #9628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @pkedvessy for the change. I had only one comment, otherwise I think we are good to go
| @@ -48,7 +48,8 @@ After downloading the binary and extracting it, to run the MiNiFi Toolkit Conver | |||
| java org.apache.nifi.minifi.toolkit.configuration.ConfigMain <command> options | |||
|
|
|||
| Valid commands include: | |||
| transform-yml: Transforms legacy MiNiFi flow config YAML into MiNiFi flow config JSON | |||
| - transform-nifi: Transform NiFi2 flow JSON format into MiNifi flow JSON format | |||
There was a problem hiding this comment.
Many thanks for updating the documentation!
...main/java/org/apache/nifi/minifi/toolkit/configuration/json/TransformNifiCommandFactory.java
Outdated
Show resolved
Hide resolved
…of maxTimerDrivenThreadCount and update minifi-toolkit command set with examples
|
@briansolo1985 Thanks for your review and feedback. I addressed your suggestion. |
|
Thank you for incorporating the change. Looks good, +1 from my side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-14149
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-14149NIFI-14149Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation