Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arch: fe310: Fix mstatus handlings #55

Merged
merged 1 commit into from
Jan 8, 2020
Merged

arch: fe310: Fix mstatus handlings #55

merged 1 commit into from
Jan 8, 2020

Conversation

masayuki2009
Copy link
Contributor

Summary

  • This PR fixes incorrect mstatus.mie initial setting introduced in previous commit.
  • Also, refactor mstatus.mpp settings.

Impact

  • This PR only affects interrupt handlings on FE310

Testing

  • I only tested this PR with nsh commands on qemu and also checked with gdb.

@masayuki2009
arch: fe310: Fix mstatus handling
ed39676 
In previous commit, mstatus.mie was set when creating a new task
but this change was incorrect and had a side effect such that
a machine interrupt would be enabled just before returning from
interrupt handling routine to switch context.

Also, mstatus.mpp is set to machine mode in up_get_newintctx()
instead of fe310_dispatch_irq().
@acassis acassis changed the base branch from master to pr55 January 8, 2020 13:35
@acassis acassis merged commit a804320 into apache:pr55 Jan 8, 2020
@masayuki2009 masayuki2009 mentioned this pull request Jan 9, 2020
Merged
@masayuki2009 masayuki2009 deleted the fix_fe310_mstatus branch March 20, 2020 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masayuki2009 @acassis