-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add if_match support #1748
Comments
Or maybe I can try it, can you assign it to me? |
I have assigned this issue to you. Have fun! |
Hello, @tobehardest. Do you need help with this issue? I'm available to answer any questions you may have. |
Hi @Xuanwo , I want to take a try. Could you assign it to me? IIUC, what I need to do is just like Another other thing to concern? One of my other questions is how to write integration tests for this case? |
Yes!
Good question. To write integration test for this feature, we need #1752 first. In strict mode, backend should return |
OK. Great, Strict Mode would help a lot for different backend services with/without the support of But even without "Strict Mode", I could still write some integration tests, right? I want to know how to write integration tests with for the |
Sadly, we can't write this test without |
If-Match
is part of HTTP standards. And many storage service support it for conditional requests.To support
If-Match
for services, we need to:if_match
fromOpRead
/OpStat
, for example: https://opendal.apache.org/docs/rust/opendal/ops/struct.OpRead.html#method.if_matchIf-Match
header for request, for examplehttps://github.com/apache/incubator-opendal/blob/92e0aefe0f7eceae11a6f45c6b8088764c5c780c/core/src/services/obs/core.rs#L96-L98
Tasks
The text was updated successfully, but these errors were encountered: