Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Add if-match support in OpRead/OpWrite/OpStat #1966

Closed
Tracked by #1748
Xuanwo opened this issue Apr 14, 2023 · 9 comments · Fixed by #2017
Closed
Tracked by #1748

core: Add if-match support in OpRead/OpWrite/OpStat #1966

Xuanwo opened this issue Apr 14, 2023 · 9 comments · Fixed by #2017
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Apr 14, 2023

No description provided.

@Xuanwo Xuanwo mentioned this issue Apr 14, 2023
Closed
7 tasks
@Xuanwo Xuanwo added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 14, 2023
@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 14, 2023

cc @STRRL, more detailed discussion could happen here.

@Xuanwo Xuanwo mentioned this issue Apr 15, 2023
Closed
@xyjixyjixyji
Copy link
Contributor

Please assign to me, I can get this done and others could move forward implementing if-match on other services.

@xyjixyjixyji
Copy link
Contributor

And by the way, why we want conditional header in OpWrite?

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 15, 2023 •
edited
Loading

I believe this issue has been taken by @STRRL. Hi, do you have time to finish this issue?

@xyjixyjixyji
Copy link
Contributor

I believe this issue has been taken by @STRRL. Hi, do you have time to finish this issue?

Sorry, my bad. I thought that is only related to S3.

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 15, 2023

And by the way, why we want conditional header in OpWrite?

user can only write to a path when its etag matches to avoid concurrent write conflict.

@suyanhanx

This comment was marked as off-topic.

Sign in to view
@Xuanwo

This comment was marked as off-topic.

Sign in to view
@Essoz Essoz mentioned this issue Apr 16, 2023
Closed
@STRRL
Copy link
Contributor

STRRL commented Apr 17, 2023

I believe this issue has been taken by @STRRL. Hi, do you have time to finish this issue?

Yeah! I am working on it! ❤️

@STRRL STRRL mentioned this issue Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add If-Match Support for OpRead, OpWrite, OpStat STRRL/opendal
4 participants
@Xuanwo @STRRL @suyanhanx @xyjixyjixyji