Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcs: Add cache-control support #1962

Closed
Tracked by #1747
Xuanwo opened this issue Apr 14, 2023 · 7 comments
Closed
Tracked by #1747

gcs: Add cache-control support #1962

Xuanwo opened this issue Apr 14, 2023 · 7 comments
Assignees
@fatelei
Labels
good first issue Good for newcomers help wanted Extra attention is needed services/gcs

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Apr 14, 2023

No description provided.

@Xuanwo Xuanwo mentioned this issue Apr 14, 2023
Closed
7 tasks
@Xuanwo Xuanwo added good first issue Good for newcomers help wanted Extra attention is needed services/gcs labels Apr 14, 2023
@fatelei
Copy link
Contributor

fatelei commented Apr 14, 2023

so, i try this one

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 14, 2023

so, i try this one

Thanks a lot. Have fun!

@fatelei fatelei mentioned this issue Apr 25, 2023
Merged
@suyanhanx
Copy link
Member

For gcs, it's a bit complicated.
https://cloud.google.com/storage/docs/json_api/v1/objects/insert#request-body
https://cloud.google.com/storage/docs/json_api/v1/objects#resource

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 27, 2023

This task should be finished after we have implement AsyncBody::Multipart which allow passing multiple parts.

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 25, 2023 •
edited
Loading

Hi @fatelei, we have implement the multipart internally. Do you still have interest in this issue?

@fatelei
Copy link
Contributor

fatelei commented Aug 25, 2023

Hi @fatelei, we have implement the multipart internally. Do you still have interest in this issue?

ok

@fatelei fatelei mentioned this issue Aug 29, 2023
Merged
@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 31, 2023

Thanks!

@Xuanwo Xuanwo closed this as completed Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fatelei fatelei

Labels
good first issue Good for newcomers help wanted Extra attention is needed services/gcs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fatelei @Xuanwo @suyanhanx