Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Authorization logic for WebdavBackend #1348

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Conversation

Young-Flash
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

if username and password aren't set, the http request needn't authorization

Summary about this PR

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I left some comments, PTAL.

src/services/webdav/backend.rs Outdated Show resolved Hide resolved
src/services/webdav/backend.rs Outdated Show resolved Hide resolved
src/services/webdav/backend.rs Outdated Show resolved Hide resolved
src/services/webdav/backend.rs Show resolved Hide resolved
@Xuanwo Xuanwo changed the title modify authorization logic for WebdavBackend refactor: Authorization logic for WebdavBackend Feb 16, 2023
@Xuanwo
Copy link
Member

Xuanwo commented Feb 16, 2023

Thanks for your contribution!

@Xuanwo Xuanwo merged commit 1e6b489 into apache:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants