Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Entry refactoring to allow external creation #1547

Merged
merged 3 commits into from
Mar 9, 2023
Merged

feat: Entry refactoring to allow external creation #1547

merged 3 commits into from
Mar 9, 2023

Conversation

damooo
Copy link
Contributor

@damooo damooo commented Mar 9, 2023 •
edited by Xuanwo
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Close #1545

@damooo
Copy link
Contributor Author

damooo commented Mar 9, 2023

I feel having mode set as Unknown without checking is still dirty, as we have to take care at flag checks and merging. Proper way will be to have Option<Metadata> as the value for cached_metadata instead of Metadata.

@Xuanwo Xuanwo changed the title feat: Entry refactoring to allow external creation. feat: Entry refactoring to allow external creation Mar 9, 2023
Xuanwo
Xuanwo reviewed Mar 9, 2023
View reviewed changes
src/types/entry.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo reviewed Mar 9, 2023
View reviewed changes
src/types/entry.rs Outdated Show resolved Hide resolved
src/types/entry.rs Show resolved Hide resolved
src/types/entry.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks a lot!

@Xuanwo Xuanwo merged commit a540559 into apache:main Mar 9, 2023
@damooo damooo deleted the entry-refactor branch March 9, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Entry constructor public.
2 participants
@damooo @Xuanwo