Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename binaries to bin #1714

Merged
merged 1 commit into from
Mar 21, 2023
Merged

chore: rename binaries to bin #1714

merged 1 commit into from
Mar 21, 2023

Conversation

tisonkun
Copy link
Member

cc @Xuanwo

binaries is not a common name. Suggest to either rename to bin or flatten to the top-level. But it can be varied from person to person. So it's no more than a suggestion.

This change is not user aware.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's do this.

@Xuanwo Xuanwo merged commit a1810d5 into apache:main Mar 21, 2023
@tisonkun tisonkun deleted the binaries-bin branch March 21, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants