Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Add checks before doing copy #1845

Merged
merged 1 commit into from
Apr 3, 2023
Merged

fix(core): Add checks before doing copy #1845

merged 1 commit into from
Apr 3, 2023

Conversation

suyanhanx
Copy link
Member

Add necessary operations before doing copy

  • ensure source file
  • ensure target parent path

@Xuanwo
Copy link
Member

Xuanwo commented Apr 3, 2023

Thanks a lot!

@Xuanwo Xuanwo changed the title fix(core): necessary operations before doing copy fix(core): Add checks before doing copy Apr 3, 2023
@Xuanwo Xuanwo merged commit 3dbccbb into apache:main Apr 3, 2023
@suyanhanx suyanhanx deleted the fix-cp-ensure-path branch April 3, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo left review comments

@ClSlaid ClSlaid ClSlaid approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suyanhanx @Xuanwo @ClSlaid