Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services/oss): remove unused builder prop allow_anonymous #1913

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

suyanhanx
Copy link
Member

No description provided.

@Xuanwo
Copy link
Member

Xuanwo commented Apr 11, 2023

No, we need this. Please return Ok(None) in load_credentail if this has been enabled.

@Xuanwo
Copy link
Member

Xuanwo commented Apr 11, 2023

No, we need this. Please return Ok(None) in load_credentail if this has been enabled.

Please take s3's load_credential as an example.

@suyanhanx
Copy link
Member Author

Please take s3's load_credential as an example.

I see.

@suyanhanx suyanhanx force-pushed the oss-remove-allow-anonymous branch from 4d3d55e to 4445c7e Compare April 11, 2023 15:46
@suyanhanx suyanhanx changed the title chore(services/oss): remove unused prop allow_anonymous feat(services/oss): reuse allow_anonymous Apr 11, 2023
@suyanhanx suyanhanx force-pushed the oss-remove-allow-anonymous branch from 4445c7e to 341e08d Compare April 11, 2023 16:03
@suyanhanx suyanhanx force-pushed the oss-remove-allow-anonymous branch from 341e08d to 7cf33c4 Compare April 11, 2023 16:04
@suyanhanx suyanhanx changed the title feat(services/oss): reuse allow_anonymous feat(services/oss): remove unused builder prop allow_anonymous Apr 11, 2023
@Xuanwo Xuanwo merged commit 8c6d502 into main Apr 11, 2023
@Xuanwo Xuanwo deleted the oss-remove-allow-anonymous branch April 11, 2023 16:12
wcy-fdu pushed a commit to wcy-fdu/opendal that referenced this pull request Apr 12, 2023
…e#1913)

chore(services/oss): remove unused builder prop allow_anonymous

Signed-off-by: suyanhanx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants