Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add if-match support for OSS #2034

Merged
merged 3 commits into from
Apr 19, 2023
Merged

add if-match support for OSS #2034

merged 3 commits into from
Apr 19, 2023

Conversation

Renkai
Copy link
Contributor

@Renkai Renkai commented Apr 18, 2023

This closes #1971

Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you are missing get.

@Xuanwo
Copy link
Member

Xuanwo commented Apr 19, 2023

It seems that you are missing get.

Hi, @Renkai, it's Ok to get this PR merged first if you prefer to start a new PR for read support.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Xuanwo Xuanwo merged commit b6d7e0e into apache:main Apr 19, 2023
@Xuanwo Xuanwo mentioned this pull request Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oss: Add if-match support
3 participants