-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Polish Writer API by merging append and write together #2036
Conversation
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Seems like you're using |
DONE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on ci green.
Signed-off-by: Xuanwo <[email protected]>
If users want to overwrite multiple times and then rollback, they will no longer be able to use the WDYT? |
I didn't understand these use cases. Could you provide more details? |
I think this is a problem of mixing |
No, we are confused many things together here. After this PRs change, there is no If users specified the size for
In general, we will hide all the impelment details inside services. The only thing for users to use is |
Great explanation! I think this needs to be in the documentation. |
This PR introduces the following changes:
append
fromOpWrite
: this arg is confusing.content_length
inOpWrite
so that services can handle sized and unsized input by themselvesAfter all these changes, users only need to use
write
instead ofappend
.This change will make our writer's behavior more easy to understand.