Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add tools to generate NOTICE and all deps licenses #2205

Merged
merged 8 commits into from
May 4, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented May 4, 2023

No description provided.

Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo requested review from PsiACE, ClSlaid and sundy-li as code owners May 4, 2023 10:45
Xuanwo added 4 commits May 4, 2023 18:47
@Xuanwo Xuanwo changed the title ci: Add tools to generate all deps licenses ci: Add tools to generate NOTICE and all deps licenses May 4, 2023
@Xuanwo Xuanwo requested a review from tisonkun May 4, 2023 11:04
@Xuanwo
Copy link
Member Author

Xuanwo commented May 4, 2023

Hi, @tisonkun, would you like to help review this PR?

Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but not sure if all original text must be maintained in our repo

Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at some deps' licenses generated and found that they don't match reality. For example, napi, your tool generates an empty file, when in fact even if it does generate a mit license which is chosen by napi, it doesn't match the corresponding one because its contents have been changed by the author.

https://github.com/napi-rs/napi-rs/blob/main/LICENSE

@Xuanwo
Copy link
Member Author

Xuanwo commented May 4, 2023

For example, napi, your tool generates an empty file, when in fact even if it does generate a mit license which is chosen by napi, it doesn't match the corresponding one because its contents have been changed by the author.

First of all, it's a bug of skywalking-eyes which should be reported back.

Then, the napi crate declare itself a MIT crate which is true.

And I think we don't need to include all licenses in our repo too, they are all declared in our NOTICE.

I will wait for @tisonkun's comment.

Xuanwo added 2 commits May 4, 2023 20:02
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
@suyanhanx
Copy link
Member

It seems better now.

Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Maybe add a CI workflow to assert the NOTICE file is up-to-date.

Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo merged commit 6cdd0c2 into main May 4, 2023
@Xuanwo Xuanwo deleted the generate-licenses branch May 4, 2023 15:32
@Xuanwo Xuanwo mentioned this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants