Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate service dashmap #2225

Merged
merged 8 commits into from
May 8, 2023
Merged

feat: migrate service dashmap #2225

merged 8 commits into from
May 8, 2023

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented May 7, 2023

@PsiACE PsiACE marked this pull request as ready for review May 7, 2023 16:11
@PsiACE PsiACE requested review from ClSlaid and sundy-li as code owners May 7, 2023 16:11
@PsiACE PsiACE requested a review from Xuanwo May 7, 2023 16:12
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Xuanwo Xuanwo merged commit 18c9e03 into apache:main May 8, 2023
@PsiACE PsiACE deleted the dashmap-typed branch May 8, 2023 03:40
suyanhanx pushed a commit to suyanhanx/opendal that referenced this pull request May 8, 2023
* feat(typed_kv): add scan support for Typed KV Adapter

Signed-off-by: Chojan Shang <[email protected]>

* feat(services/dashmap): migrate service dashmap

Signed-off-by: Chojan Shang <[email protected]>

* fix(services/dashmap): return inner

Signed-off-by: Chojan Shang <[email protected]>

* feat(services/moka): try to enable scan

Signed-off-by: Chojan Shang <[email protected]>

* refactor(typed_kv): scan is not available for all typed kv services

Signed-off-by: Chojan Shang <[email protected]>

* feat(typed_kv): also add KvPager

Signed-off-by: Chojan Shang <[email protected]>

* feat(typed_kv): add typed_kv::Info to carry capability check back

Signed-off-by: Chojan Shang <[email protected]>

* feat(typed_kv): add typed_kv::Capability

Signed-off-by: Chojan Shang <[email protected]>

---------

Signed-off-by: Chojan Shang <[email protected]>
@Xuanwo Xuanwo mentioned this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants