Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add presign support for obs #2253

Merged
merged 2 commits into from
May 16, 2023

Conversation

cuichenli
Copy link
Contributor

fixes: #2070

noticed that oss already have the presign support, so this pr only touches obs.

@cuichenli
Copy link
Contributor Author

some side notes:

noticed there are a lot of code duplicates, for instance: obs_get_head_object_request and obs_get_head_object share the same logic on setup the req object, not sure if it would be worth to extract the shared logic?

also for the sign_query method, not sure if it would be worth to make it as a trait?

core/src/services/obs/core.rs Show resolved Hide resolved
core/src/services/obs/core.rs Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Member

Xuanwo commented May 11, 2023

not sure if it would be worth to extract the shared logic?

We can call xxx_request in xxx.

also for the sign_query method, not sure if it would be worth to make it as a trait?

Make it a trait is not helpful because one service one has one valid sign_query implementaion.

@cuichenli
Copy link
Contributor Author

thanks, updated based on the comments above.

@cuichenli cuichenli requested review from Xuanwo and suyanhanx May 16, 2023 03:34
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's go.

@suyanhanx suyanhanx merged commit 239d3ed into apache:main May 16, 2023
@Xuanwo Xuanwo mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add supporting presign for other cloud storage services
3 participants