Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services/dropbox): Support create/read/delete for Dropbox #2264

Merged
merged 1 commit into from
Jun 20, 2023
Merged

feat(services/dropbox): Support create/read/delete for Dropbox #2264

merged 1 commit into from
Jun 20, 2023

Conversation

Zheaoli
Copy link
Member

@Zheaoli Zheaoli commented May 15, 2023 •
edited by suyanhanx
Loading

close #1098

@Zheaoli Zheaoli marked this pull request as draft May 15, 2023 17:55
@Zheaoli Zheaoli force-pushed the manjusaka/support-dropbox branch from 13e933e to 428fabe Compare May 15, 2023 17:56
@suyanhanx

This comment was marked as outdated.

Sign in to view
Xuanwo
Xuanwo reviewed May 16, 2023
View reviewed changes
core/src/services/mod.rs Show resolved Hide resolved
core/src/services/dropbox/backend.rs Outdated Show resolved Hide resolved
core/src/services/dropbox/builder.rs Outdated Show resolved Hide resolved
core/src/services/dropbox/core.rs Outdated Show resolved Hide resolved
core/src/services/dropbox/core.rs Outdated Show resolved Hide resolved
core/src/services/dropbox/core.rs Outdated Show resolved Hide resolved
@Zheaoli Zheaoli force-pushed the manjusaka/support-dropbox branch from 3487389 to 837bf9a Compare June 17, 2023 14:44
@Zheaoli Zheaoli changed the title [WIP]feat(services/dropbox): Support create/read/rename/copy/delete for Dropbox [WIP]feat(services/dropbox): Support create/read/delete for Dropbox Jun 17, 2023
@Zheaoli Zheaoli requested a review from Xuanwo June 17, 2023 14:47
@suyanhanx
Copy link
Member

We updated the raw API a while ago and added sink support for the writer. Please update, thanks.

@Zheaoli Zheaoli marked this pull request as ready for review June 17, 2023 17:46
@Zheaoli Zheaoli changed the title [WIP]feat(services/dropbox): Support create/read/delete for Dropbox feat(services/dropbox): Support create/read/delete for Dropbox Jun 17, 2023
Xuanwo
Xuanwo reviewed Jun 18, 2023
View reviewed changes
core/src/services/dropbox/error.rs Show resolved Hide resolved
core/src/services/dropbox/core.rs Outdated Show resolved Hide resolved
core/src/services/dropbox/core.rs Outdated Show resolved Hide resolved
core/src/services/dropbox/core.rs Outdated Show resolved Hide resolved
core/src/services/dropbox/core.rs Outdated Show resolved Hide resolved
@Zheaoli Zheaoli force-pushed the manjusaka/support-dropbox branch 2 times, most recently from dec8a69 to 6c4b8bf Compare June 18, 2023 17:26
@Zheaoli Zheaoli force-pushed the manjusaka/support-dropbox branch 2 times, most recently from 77132fa to c08d98d Compare June 19, 2023 15:44
@Zheaoli Zheaoli requested a review from Xuanwo June 19, 2023 15:56
@Zheaoli Zheaoli force-pushed the manjusaka/support-dropbox branch from c08d98d to 3bdc51a Compare June 19, 2023 15:57
Xuanwo
Xuanwo reviewed Jun 20, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. Thanks for you work! The thing left here maybe make clippy happy.

@Zheaoli Zheaoli requested review from Xuanwo and suyanhanx June 20, 2023 09:50
@Zheaoli Zheaoli force-pushed the manjusaka/support-dropbox branch 4 times, most recently from 0882719 to 075041b Compare June 20, 2023 11:57
@Zheaoli Zheaoli force-pushed the manjusaka/support-dropbox branch from 075041b to 7952b47 Compare June 20, 2023 11:59
Xuanwo
Xuanwo reviewed Jun 20, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Xuanwo
Xuanwo approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit f7e175d into apache:main Jun 20, 2023
@Zheaoli Zheaoli deleted the manjusaka/support-dropbox branch June 20, 2023 14:52
@PsiACE PsiACE mentioned this pull request Jun 27, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

@suyanhanx suyanhanx Awaiting requested review from suyanhanx

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Dropbox Support
3 participants
@Zheaoli @suyanhanx @Xuanwo