Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(bindings/c): Add diff check #2359

Merged
merged 2 commits into from
May 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/bindings_c.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,17 @@ jobs:
sudo cp lib/*.a /usr/lib
sudo ln -s /usr/lib/libgtest.a /usr/local/lib/libgtest.a
sudo ln -s /usr/lib/libgtest_main.a /usr/local/lib/libgtest_main.a

- name: Setup Rust toolchain
uses: ./.github/actions/setup

- name: Build C binding
working-directory: "bindings/c"
run: make build

- name: Check diff
run: git diff --exit-code

- name: Build and Run BDD tests
working-directory: "bindings/c"
run: make test

16 changes: 11 additions & 5 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,17 @@

name: Docs

on: [push]
on:
push:
branches:
- main
pull_request:
branches:
- main
paths:
- "core/**"
- "bindings/**"
- ".github/workflows/docs.yml"

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
Expand Down Expand Up @@ -130,7 +140,6 @@ jobs:
steps:
- uses: actions/checkout@v3

# Set node.js environment -----------------------------------------
- uses: actions/setup-node@v3
with:
node-version: '16'
Expand All @@ -148,7 +157,6 @@ jobs:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}

# Download docs ---------------------------------------------------
- name: Download rust docs
uses: actions/download-artifact@v2
with:
Expand All @@ -173,7 +181,6 @@ jobs:
name: java-docs
path: ./website/static/docs/java

# Build website ---------------------------------------------------
- name: Install Dependencies
working-directory: website
run: yarn install
Expand All @@ -182,7 +189,6 @@ jobs:
working-directory: website
run: yarn build

# Start deploy --------------------------------------------------
- name: Copy asf file
run: cp .asf.yaml ./website/build/.asf.yaml

Expand Down
2 changes: 1 addition & 1 deletion bindings/c/include/opendal.h
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ typedef struct BlockingOperator BlockingOperator;
typedef struct HashMap_String__String HashMap_String__String;

/*
Metadata carries all metadata associated with an path.
Metadata carries all metadata associated with a path.

# Notes

Expand Down