Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services/redb): support redb service #2526

Merged
merged 9 commits into from
Jun 25, 2023
Merged

feat(services/redb): support redb service #2526

merged 9 commits into from
Jun 25, 2023

Conversation

oowl
Copy link
Member

@oowl oowl commented Jun 24, 2023 •
edited
Loading

introduce new redb service #2524

@oowl oowl marked this pull request as draft June 24, 2023 17:16
@oowl oowl force-pushed the feat/service/redb branch from 4c228ef to d196a3c Compare June 24, 2023 17:43
Xuanwo
Xuanwo reviewed Jun 25, 2023
View reviewed changes
core/Cargo.toml Outdated Show resolved Hide resolved
core/src/services/redb/backend.rs Outdated Show resolved Hide resolved
core/src/services/redb/backend.rs Outdated Show resolved Hide resolved
@oowl oowl force-pushed the feat/service/redb branch from a3a66b1 to d4227cc Compare June 25, 2023 15:06
@oowl oowl marked this pull request as ready for review June 25, 2023 16:19
@Xuanwo
Copy link
Member

Xuanwo commented Jun 25, 2023

Sorry for the CI failure, fixed in #2534

@oowl
Copy link
Member Author

oowl commented Jun 25, 2023

@Xuanwo https://github.com/apache/incubator-opendal/actions/runs/5370716502/jobs/9743000170?pr=2526 and this error, it seems we are using old MSRV version.

@Xuanwo
Copy link
Member

Xuanwo commented Jun 25, 2023 •
edited
Loading

@Xuanwo https://github.com/apache/incubator-opendal/actions/runs/5370716502/jobs/9743000170?pr=2526 and this error, it seems we are using old MSRV version.

Please remove redb from default feature. It's required that opendal with default feature must work on MSRV.

@oowl
Copy link
Member Author

oowl commented Jun 25, 2023

waiting for #2534 merged and rebase for fix CI failed.

Xuanwo
Xuanwo approved these changes Jun 25, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 65898d3 into apache:main Jun 25, 2023
@oowl oowl mentioned this pull request Jun 26, 2023
Merged
@PsiACE PsiACE mentioned this pull request Jun 27, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oowl @Xuanwo