Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services/etcd): introduce new service backend etcd #2672

Merged
merged 6 commits into from
Jul 21, 2023
Merged

feat(services/etcd): introduce new service backend etcd #2672

merged 6 commits into from
Jul 21, 2023

Conversation

G-XD
Copy link
Contributor

@G-XD G-XD commented Jul 19, 2023

Xuanwo
Xuanwo reviewed Jul 19, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Your code is perfect!

core/src/types/scheme.rs Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Member

Xuanwo commented Jul 19, 2023

CI failed for we don't have protoc installed. Let me take a look.

@Xuanwo
Copy link
Member

Xuanwo commented Jul 20, 2023

Hi, I have added protoc in #2674, would you like to take another try?

@G-XD
Copy link
Contributor Author

G-XD commented Jul 20, 2023 •
edited
Loading

Hi, check_clippy and Service Test WebDAV are failed, do I just need to fix the check_clippy related errors?

@Xuanwo
Copy link
Member

Xuanwo commented Jul 20, 2023 •
edited
Loading

Please ignore the error happened in Service Test WebDAV, we are working on addressing it.

For check_clippy errors: yes, please fix all of them.

@G-XD
Copy link
Contributor Author

G-XD commented Jul 21, 2023

Please ignore the error happened in Service Test WebDAV, we are working on addressing it.

For check_clippy errors: yes, please fix all of them.

Hi, I'm done and it looks fine.

Xuanwo
Xuanwo approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Xuanwo Xuanwo merged commit 5750dfc into apache:main Jul 21, 2023
@Xuanwo
Copy link
Member

Xuanwo commented Jul 21, 2023

Would you like to add an integration test for etcd service?

@G-XD
Copy link
Contributor Author

G-XD commented Jul 21, 2023

Okay, I'll try it.

@Xuanwo
Copy link
Member

Xuanwo commented Jul 21, 2023

Okay, I'll try it.

Thanks a lot!

@oowl oowl mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@G-XD @Xuanwo