Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test): add fuzz target for writer #2706

Merged
merged 5 commits into from
Jul 25, 2023
Merged

feat(test): add fuzz target for writer #2706

merged 5 commits into from
Jul 25, 2023

Conversation

dqhl76
Copy link
Member

@dqhl76 dqhl76 commented Jul 24, 2023 •
edited
Loading

part of: #2551

also split reader and range reader, ref: #2609 (comment)

@dqhl76 dqhl76 requested a review from Xuanwo as a code owner July 24, 2023 09:49
@dqhl76 dqhl76 changed the title feat: add fuzz target for writer feat(test): add fuzz target for writer Jul 24, 2023
@dqhl76 dqhl76 mentioned this pull request Jul 16, 2023
Closed
3 tasks
Xuanwo
Xuanwo reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM!

core/fuzz/fuzz_reader.rs Outdated Show resolved Hide resolved
@dqhl76 dqhl76 marked this pull request as draft July 24, 2023 10:13
@dqhl76 dqhl76 marked this pull request as ready for review July 25, 2023 01:46
@dqhl76
Copy link
Member Author

dqhl76 commented Jul 25, 2023

I reviewed libfuzzer's guide. It request us to minimize the fuzz target. So I split range reader to a individual fuzz target.
https://llvm.org/docs/LibFuzzer.html#id23

@dqhl76 dqhl76 requested a review from Xuanwo July 25, 2023 01:57
Xuanwo
Xuanwo approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Xuanwo Xuanwo merged commit 007565b into apache:main Jul 25, 2023
@oowl oowl mentioned this pull request Jul 28, 2023
Merged
@dqhl76 dqhl76 deleted the fuzz-writer branch August 3, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dqhl76 @Xuanwo