Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add override_content_type #2734

Merged
merged 2 commits into from
Jul 31, 2023
Merged

feat: add override_content_type #2734

merged 2 commits into from
Jul 31, 2023

Conversation

G-XD
Copy link
Contributor

@G-XD G-XD commented Jul 31, 2023

fix #2724

@Xuanwo
Copy link
Member

Xuanwo commented Jul 31, 2023

error: this function has too many arguments (8/7)
   --> core/src/services/s3/core.rs:242:5
    |
242 | /     pub fn s3_get_object_request(
243 | |         &self,
244 | |         path: &str,
245 | |         range: BytesRange,
...   |
250 | |         if_match: Option<&str>,
251 | |     ) -> Result<Request<AsyncBody>> {
    | |___________________________________^
    |
    = note: `-D clippy::too-many-arguments` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Ooops, maybe we can fix this by passing OpRead instead.

@G-XD
Copy link
Contributor Author

G-XD commented Jul 31, 2023

error: this function has too many arguments (8/7)
   --> core/src/services/s3/core.rs:242:5
    |
242 | /     pub fn s3_get_object_request(
243 | |         &self,
244 | |         path: &str,
245 | |         range: BytesRange,
...   |
250 | |         if_match: Option<&str>,
251 | |     ) -> Result<Request<AsyncBody>> {
    | |___________________________________^
    |
    = note: `-D clippy::too-many-arguments` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Ooops, maybe we can fix this by passing OpRead instead.

Done.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

@Xuanwo Xuanwo merged commit ad7952f into apache:main Jul 31, 2023
@oowl oowl mentioned this pull request Jul 31, 2023
@G-XD G-XD deleted the feat_override_content_type branch August 15, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add override_content_type for FuturePresignRead
2 participants