feat: Add FoundationDB Support for OpenDAL #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyanhanx
reviewed
Aug 1, 2023
Xuanwo
reviewed
Aug 1, 2023
ArmandoZ
force-pushed
the
add_foundationdb
branch
8 times, most recently
from
0a973da to
8501b2c
Compare
ArmandoZ
force-pushed
the
add_foundationdb
branch
from
8501b2c to
96f6277
Compare
suyanhanx
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FoundationDB Support (write, read) for OpenDAL, related issue: #2650
For testing:
cargo test foundationdb --features services-foundationdb -j=1Issue to be discussed: Instead of passing in parameters like
data_dir, foundationdb API only takes path of configuration file for config (API Doc). Current implementation in this PR only uses default configuration path - I'm not sure whether to make the path configurable (user can pass in different configuration paths), or let user modify the default configuration file before using.