Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC-2779: List With Metakey #2779

Merged
merged 10 commits into from
Aug 7, 2023
Merged

RFC-2779: List With Metakey #2779

merged 10 commits into from
Aug 7, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Aug 4, 2023

Close #2763

Xuanwo added 2 commits August 4, 2023 17:54
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo changed the title RFC: List With Metakey RFC-2779: List With Metakey Aug 4, 2023
Xuanwo added 2 commits August 4, 2023 17:57
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Xuanwo added 3 commits August 4, 2023 20:43
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@xyjixyjixyji
Copy link
Contributor

+1, nice work

Copy link
Member

@oowl oowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me, Thanks!

Copy link
Member

@silver-ymz silver-ymz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 7, 2023

Thanks a lot, I will add more context in this RFC and than merge it.

@Xuanwo Xuanwo merged commit 63cfcf0 into main Aug 7, 2023
@Xuanwo Xuanwo deleted the add-lister-query branch August 7, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

idea: Allow op.list() to accept Metakey query
5 participants