Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix behaivor tests for blocking layer #2809

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Aug 8, 2023

fix #2807

@Xuanwo Xuanwo requested a review from PsiACE as a code owner August 8, 2023 03:54
@Xuanwo Xuanwo requested a review from suyanhanx August 8, 2023 03:54
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 8, 2023

owncloud keeps failing on

  2023-08-08T04:00:58.930013Z ERROR opendal::services: service=webdav operation=blocking_copy from=1a594b31-260e-43fc-b48f-9afcf43b78ae to=57e9e95f-3b50-4f7e-8e61-e8cb999a92c6 -> failed: Unexpected (temporary) at copy => <?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\DAV\Exception\ServiceUnavailable</s:exception>
  <s:message>OCP\Lock\LockedException: "Documents" is locked</s:message>
</d:error>


Context:
    uri: http://127.0.0.1:8080/remote.php/webdav//7e49f03e-d46a-4446-9a71-08add40a9b3e/
    response: Parts { status: 503, version: HTTP/1.1, headers: {"date": "Tue, 08 Aug 2023 04:00:58 GMT", "server": "Apache", "x-content-type-options": "nosniff", "x-xss-protection": "0", "x-robots-tag": "none", "x-frame-options": "SAMEORIGIN", "x-download-options": "noopen", "x-permitted-cross-domain-policies": "none", "content-type": "application/xml; charset=utf-8", "expires": "Thu, 19 Nov 1981 08:52:00 GMT", "cache-control": "no-store, no-cache, must-revalidate", "pragma": "no-cache", "content-security-policy": "default-src 'none';", "content-length": "249", "connection": "close"} }
    service: webdav
    from: 1a594b31-260e-43fc-b48f-9afcf43b78ae
    to: 57e9e95f-3b50-4f7e-8e61-e8cb999a92c6

    at core/src/layers/logging.rs:825

thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
  left: `Unexpected`,
 right: `NotFound`', core/tests/behavior/blocking_copy.rs:68:5

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 8, 2023

Ok, I found the root cause: retry is not implemented on blocking_copy and blocking_rename.

@Xuanwo Xuanwo merged commit b87fa5a into main Aug 8, 2023
@Xuanwo Xuanwo deleted the fix-behavor-test-for-blocking-layer branch August 8, 2023 06:10
@suyanhanx
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

behavior tests failed after enabling blocking layer
3 participants