Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(oli): Fix a test name in ls.rs #2817

Merged
merged 2 commits into from
Aug 8, 2023
Merged

fix(oli): Fix a test name in ls.rs #2817

merged 2 commits into from
Aug 8, 2023

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Aug 8, 2023

As I reported in #2816, a test name in ls.rs is wrong.
test_basic_ls seems correct.

@sarutak sarutak requested review from Xuanwo and PsiACE as code owners August 8, 2023 17:39
@sarutak sarutak changed the title Fix a test name in ls.rs fix(oli) Fix a test name in ls.rs Aug 8, 2023
@Xuanwo Xuanwo changed the title fix(oli) Fix a test name in ls.rs fix(oli): Fix a test name in ls.rs Aug 8, 2023
Xuanwo
Xuanwo approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 7771554 into apache:main Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

Assignees
No one assigned
Labels
releases-note/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarutak @Xuanwo