feat: Add clippy rule to avoid wrong usage of tempfile crate #2836
Conversation
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| disallowed-methods = [ |
There was a problem hiding this comment.
I prefer fix this instead of adding new clippy rules. Maybe we can call tempfile.close() by hand?
There was a problem hiding this comment.
I think it's difficult to change the behavior of TempDir::into_path because it's not a bug. It's a specification.
We can delete manually by fs::remove_dir_all (tempfile.close doesn't delete once TempDir::into_path is called) but my concern is the case someone can forget to delete by hand.
If someone don't know the behavior of TempDir::into_path, it can happen.
There was a problem hiding this comment.
Thank you for providing the information! I would like to refactor current test logic so that we don't need to create tempfile any more, thus we also don't need to add clippy rules here.
Related issue: #2835
I added tempfile crate in #2823 .
One pitfall is the usage of TempDir::into_path.
According to the API doc, TempDir::into_path leads the corresponding temporary directory not deleted automatically.
To avoid resource leak I proposes to add a clippy rule.