Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(doc): Update instructions for building the C binding in README.md #2856

Merged
merged 1 commit into from
Aug 12, 2023
Merged

fix(doc): Update instructions for building the C binding in README.md #2856

merged 1 commit into from
Aug 12, 2023

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Aug 12, 2023 •
edited
Loading

Related issue #2855

This PR aims to updates the requirements for building the C binding.
I confirmed this instructions work with a docker image of Ubuntu 22.04.

@sarutak sarutak requested a review from xyjixyjixyji as a code owner August 12, 2023 20:30
xyjixyjixyji
xyjixyjixyji approved these changes Aug 12, 2023
View reviewed changes
Copy link
Contributor

@xyjixyjixyji xyjixyjixyji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great. We do need these.

@xyjixyjixyji xyjixyjixyji merged commit 62d376a into apache:main Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xyjixyjixyji xyjixyjixyji xyjixyjixyji approved these changes

Assignees
No one assigned
Labels
releases-note/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarutak @xyjixyjixyji