Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add AtomicServer Support for OpenDAL #2878

Merged
merged 7 commits into from
Sep 15, 2023
Merged

feat: Add AtomicServer Support for OpenDAL #2878

merged 7 commits into from
Sep 15, 2023

Conversation

ArmandoZ
Copy link
Contributor

@ArmandoZ ArmandoZ commented Aug 18, 2023 •
edited
Loading

Add AtomicData Support (write, read) for OpenDAL, related issue: #2635

For testing:

@ArmandoZ ArmandoZ requested review from Xuanwo and PsiACE as code owners August 18, 2023 04:19
Xuanwo
Xuanwo reviewed Aug 18, 2023
View reviewed changes
core/src/services/atomicdata/backend.rs Outdated Show resolved Hide resolved
core/src/services/atomicdata/backend.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo reviewed Aug 19, 2023
View reviewed changes
.env.example Outdated Show resolved Hide resolved
core/src/services/atomicdata/backend.rs Outdated Show resolved Hide resolved
@ArmandoZ ArmandoZ requested a review from Xuanwo September 13, 2023 01:07
Xuanwo
Xuanwo reviewed Sep 13, 2023
View reviewed changes
core/Cargo.toml Outdated Show resolved Hide resolved
core/src/services/atomicdata/backend.rs Outdated Show resolved Hide resolved
core/src/services/atomicdata/backend.rs Outdated Show resolved Hide resolved
core/src/services/atomicdata/backend.rs Outdated Show resolved Hide resolved
core/src/services/atomicdata/backend.rs Outdated Show resolved Hide resolved
core/src/services/atomicdata/backend.rs Outdated Show resolved Hide resolved
core/src/services/atomicdata/backend.rs Outdated Show resolved Hide resolved
core/src/services/atomicdata/backend.rs Outdated Show resolved Hide resolved
core/src/services/atomicdata/backend.rs Outdated Show resolved Hide resolved
@ArmandoZ ArmandoZ force-pushed the add_atomic_data branch 2 times, most recently from 84496ef to fffbd60 Compare September 13, 2023 04:42
@ArmandoZ ArmandoZ requested a review from Xuanwo September 13, 2023 04:43
@Xuanwo
Copy link
Member

Xuanwo commented Sep 14, 2023

Hi, based on #2635 (comment), @joepio suggest us to use atmoic-server instead.

Xuanwo
Xuanwo reviewed Sep 14, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

@ArmandoZ
Copy link
Contributor Author

Thanks for the suggestion. I renamed all occurrences to atomicServer.

@Xuanwo Xuanwo changed the title feat: Add AtomicData Support for OpenDAL feat: Add AtomicServer Support for OpenDAL Sep 15, 2023
Xuanwo
Xuanwo approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your work! Really great!

@Xuanwo Xuanwo merged commit 6ff8c70 into apache:main Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArmandoZ @Xuanwo