Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(services/s3): allow 404 resp when deleting a non-existing object #2941

Merged
merged 3 commits into from
Aug 26, 2023
Merged

fix(services/s3): allow 404 resp when deleting a non-existing object #2941

merged 3 commits into from
Aug 26, 2023

Conversation

gongyisheng
Copy link
Contributor

@gongyisheng gongyisheng commented Aug 26, 2023 •
edited
Loading

gcs doesn't implement batch delete, so we can just fix single file delete this time.

@gongyisheng gongyisheng requested a review from Xuanwo as a code owner August 26, 2023 06:19
Xuanwo
Xuanwo approved these changes Aug 26, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, great patch!

@Xuanwo Xuanwo merged commit db68489 into apache:main Aug 26, 2023
@gongyisheng
Copy link
Contributor Author

@Xuanwo Appreciate your help so much

@gongyisheng gongyisheng deleted the s3_ignore_404_when_delete branch August 26, 2023 06:52
@gongyisheng
Copy link
Contributor Author

implement #2891

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gongyisheng @Xuanwo