Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove oio::Write::copy_from #3018

Merged
merged 4 commits into from
Sep 7, 2023
Merged

refactor: Remove oio::Write::copy_from #3018

merged 4 commits into from
Sep 7, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Sep 7, 2023 •
edited
Loading

@Xuanwo
Remove write can sink
f5426ff 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Fix test
982ec98 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Fix test
c3b440d 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Copy link
Member Author

Xuanwo commented Sep 7, 2023

dropbox is flaky now, please ignore for now.

suyanhanx
suyanhanx approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Xuanwo Xuanwo merged commit 098ef52 into main Sep 7, 2023
@Xuanwo Xuanwo deleted the remove-copy-from branch September 7, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xuanwo @suyanhanx